Readme addition #14
Open
Readme addition #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OptimumCode
requested changes
Jan 30, 2022
README.md
Outdated
| ####MESSAGES mode | ||
| Crawler sends messages via gRPC request to Data-Processor(Processor). The Processor does with messages whatever it wants and sends response. </br> | ||
| The response may contain mapping entries of stream to [MessageID](https://github.com/th2-net/th2-grpc-common/blob/4dd3aa2917fa1af683b6cd50ff6d250e652b6bb7/src/main/proto/th2_grpc_common/common.proto#L37). | ||
| Crawler receives and keeps this information in order </br>to resume send messages within streams since that ids in case of Processor failure. |
There was a problem hiding this comment.
No need for br in the middle of the line. It will be rendered depending on the area the document is open in
|
|
||
| ####MESSAGES mode | ||
| Crawler sends messages via gRPC request to Data-Processor(Processor). The Processor does with messages whatever it wants and sends response. </br> | ||
| The response may contain mapping entries of stream to [MessageID](https://github.com/th2-net/th2-grpc-common/blob/4dd3aa2917fa1af683b6cd50ff6d250e652b6bb7/src/main/proto/th2_grpc_common/common.proto#L37). |
There was a problem hiding this comment.
Please, add information about restrictions for those IDs: they should be from the current interval
Co-authored-by: Oleg Smirnov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.