Chesr 187 #16
Open
Chesr 187 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d/or version of crawler-data-processor
Comment on lines
263
to
270
| when(manager.getDataServiceMock().intervalStart(any(IntervalInfo.class))).thenReturn( | ||
| IntervalStartResponse.newBuilder().setStatus(Status.newBuilder().setHandshakeRequired(true).build()).build() | ||
| ); | ||
|
|
||
| crawler.process(); | ||
|
|
||
| Assertions.assertEquals(dataProcessorName, crawler.getProcessorInfo().getDataProcessorName()); | ||
| Assertions.assertEquals(dataProcessorVersion, crawler.getProcessorInfo().getDataProcessorVersion()); |
There was a problem hiding this comment.
Please extract to separate test
There was a problem hiding this comment.
There used to be assertThrows check, now there's no exception in Crawler in this case. So I just assert a correct name and version. What exactly do you want me to extract to a separate test?
OptimumCode
requested changes
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.