Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename TorConfigBuilder to TorSettingsBuilder #137

Open
sisbell opened this issue Nov 15, 2019 · 0 comments
Open

Rename TorConfigBuilder to TorSettingsBuilder #137

sisbell opened this issue Nov 15, 2019 · 0 comments

Comments

@sisbell
Copy link
Contributor

sisbell commented Nov 15, 2019

TorConfigBuilder is using TorSettings to build the torrc file. So we should rename TorConfigBuilder, especially since we have a TorConfig class already, which has nothing to do with TorConfigBuilder.
SilverGhostBS added a commit to SilverGhostBS/Tor_Onion_Proxy_Library that referenced this issue Mar 25, 2020
@SilverGhostBS
Fix: thaliproject#137
c5a6abe
@SilverGhostBS SilverGhostBS mentioned this issue Mar 25, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sisbell