Fix: #137

[SilverGhostBS]

Hello, just a naive attempt at trying to refactor this for clarity as per issue #137

Feel free to use or not, hope I didn't forget anything.

---

This change is 

[msftclas]

All CLA requirements met.

[yaronyg]

Reviewed 3 of 3 files at r1, 4 of 6 files at r2.
Reviewable status: 7 of 9 files reviewed, 2 unresolved discussions (waiting on @SilverGhostBS)

---

android/build.gradle, line 13 at r2 (raw file):

    }
    dependencies {
        classpath "com.android.tools.build:gradle:3.6.0"

Shouldn't this keep using the variable rather than hard coding?

---

android_tor_installer/build.gradle, line 13 at r2 (raw file):

    }
    dependencies {
        classpath "com.android.tools.build:gradle:3.6.0"

Same comment from other gradle file

[sisbell]

---

android/build.gradle, line 15 at r2 (raw file):

        classpath "com.android.tools.build:gradle:3.6.0"
    }
}

Do we need jcenter as a repo? jcenter seems to function as a proxy for multiple repos so I've seen the same artifiact (based on maven coordinates) have different sha values depending on whichever repo is hit.

[SilverGhostBS]

I think if you don't put it you'll have problem finding trove4j, but I'm not sure, there is a reason I added it though. Le jeu. 26 mars 2020 à 13:26, Shane Isbell <[email protected]> a écrit :

…

------------------------------ *android/build.gradle, line 15 at r2 <https://reviewable.io/reviews/thaliproject/tor_onion_proxy_library/144#-M3Ms8PL6TYWCK3EnnEs:-M3Ms8PL6TYWCK3EnnEt:bdd7hxm> (raw file <https://github.com/thaliproject/tor_onion_proxy_library/blob/c5064eb0c24aaddff697e91804d340de34126c86/android/build.gradle#L15>):* classpath "com.android.tools.build:gradle:3.6.0" } } Do we need jcenter as a repo? jcenter seems to function as a proxy for multiple repos so I've seen the same artifiact (based on maven coordinates) have different sha values depending on whichever repo is hit. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#144 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AETGQGYD3Z6WB5BKO5BYSZLRJOF4DANCNFSM4LTRGA3Q> .

[SilverGhostBS]

Reviewed 3 of 3 files at r1, 4 of 6 files at r2.
Reviewable status: 7 of 9 files reviewed, 2 unresolved discussions (waiting on @SilverGhostBS)

android/build.gradle, line 13 at r2 (raw file):

    }
    dependencies {
        classpath "com.android.tools.build:gradle:3.6.0"

Shouldn't this keep using the variable rather than hard coding?

android_tor_installer/build.gradle, line 13 at r2 (raw file):

    }
    dependencies {
        classpath "com.android.tools.build:gradle:3.6.0"

Same comment from other gradle file

Yes, I agree having it as a variable makes sense but it prevents Android Studio from suggesting you to update when a new version comes out.

[SilverGhostBS]

Plus it adds an exta "obstacle" when you want to build the android module separately from the rest

[yaronyg]

Reviewed 2 of 6 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SilverGhostBS)

[sisbell]

---

gradle.properties, line 2 at r2 (raw file):

# Configure Android Gradle Plugin Version
androidplugin=3.6.0

We would need at least gradle 5.6.4 for this version of the android plugin. The current configuration in the gradle wrapper is for 4.6. This would break the command line build.

[jollyjoker992]

@SilverGhostBS Can you fix the conflict. This PR will help us a lot for the android lib. Thanks.