[WIP]Check if storeapi series is nil before iterating #19

4n4nd · 2020-10-02T14:55:52Z

Addresses #18

bwplotka

I think we need bit different behaviour but it's close (:

bwplotka · 2020-10-02T15:56:21Z

pkg/series/storeapi/storeapi.go

@@ -91,6 +91,10 @@ func (i *iterator) Next() bool {
 	}

 	i.currentSeries = seriesResp.GetSeries()


Hey, nil is actually ok because we have different responses: warnings hints as well..

We should gather warnings at least and log them and otherwise ignore non series frames (:

umm what do you suggest how do we prevent Seg faults then?

As in 99% cases you can always check how we deal with this on Thanos (:

https://github.com/thanos-io/thanos/blob/49dad93ed67210374939aedd7a8f849a60375906/pkg/query/querier.go#L153

Check if storeapi series is nil before iterating

e20eb9d

bwplotka requested changes Oct 2, 2020

View reviewed changes

4n4nd changed the title ~~Check if storeapi series is nil before iterating~~ [WIP]Check if storeapi series is nil before iterating Oct 5, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP]Check if storeapi series is nil before iterating #19

[WIP]Check if storeapi series is nil before iterating #19

4n4nd commented Oct 2, 2020

bwplotka left a comment

bwplotka Oct 2, 2020

4n4nd Oct 2, 2020

bwplotka Oct 2, 2020

		@@ -91,6 +91,10 @@ func (i *iterator) Next() bool {
		}

		i.currentSeries = seriesResp.GetSeries()

[WIP]Check if storeapi series is nil before iterating #19

Are you sure you want to change the base?

[WIP]Check if storeapi series is nil before iterating #19

Conversation

4n4nd commented Oct 2, 2020

bwplotka left a comment

Choose a reason for hiding this comment

bwplotka Oct 2, 2020

Choose a reason for hiding this comment

4n4nd Oct 2, 2020

Choose a reason for hiding this comment

bwplotka Oct 2, 2020

Choose a reason for hiding this comment