Hedged-request: Handling in HTTP Client Configuration #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vanshikav123 <[email protected]>
|
@GiedriusS PTAL! |
GiedriusS
requested changes
May 9, 2024
| @@ -135,8 +136,15 @@ func appendHttpOptions(gc Config, opts []option.ClientOption) ([]option.ClientOp | |||
| return nil, err | |||
| } | |||
|
|
|||
| httpCli := &http.Client{ | |||
| hedgedClient, err := hedgedhttp.New(hedgedhttp.Config{ | |||
There was a problem hiding this comment.
All of this hedgedhttp.New() must be inside Thanos code, not here, because otherwise you will be forcing hedged HTTP requests on all clients of this library.
There was a problem hiding this comment.
Thank you for your assistance ! i want to confirm my query that you want me to create hedgedhttp.Client into the Thanos codebase itself, and expose a configuration option only to enable or disable hedged requests? something like this ?
| }) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| chain = []credentials.Provider{ | ||
| wrapCredentialsProvider(&credentials.EnvAWS{}), | ||
| wrapCredentialsProvider(&credentials.FileAWSCredentials{}), | ||
| wrapCredentialsProvider(&credentials.IAM{ | ||
| Client: &http.Client{ |
There was a problem hiding this comment.
The Transport need to come from this function here: https://github.com/thanos-io/objstore/blob/main/client/factory.go#L65
Vanshikav123
changed the title
Vanshikav123
changed the title
|
Hey ! @GiedriusS closing this one ! PTAL for #119 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Initiation change for
thanos-io/thanos#6712
Verification