Fix overlapping metric registrations #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonswine
force-pushed
the
20230727_allow-two-bucket-clients
branch
2 times, most recently
from
667691b
to
5d8153b
Compare
simonswine
force-pushed
the
20230727_allow-two-bucket-clients
branch
from
5d8153b
to
e218ba3
Compare
This fixes a problem when multiple metrics bucket are regsitered with different names. Also adds a test so this won't be happening in the future. Signed-off-by: Christian Simon <[email protected]>
simonswine
force-pushed
the
20230727_allow-two-bucket-clients
branch
from
e218ba3
to
c8b2d20
Compare
matej-g
approved these changes
Aug 3, 2023
kakkoyun
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem when multiple metrics bucket are registered with different names. Also adds a test so this won't be happening in the future.
This does not have an impact to the resulting metrics.