Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for timestamp #296

Closed
wants to merge 1 commit into from

Conversation

kanha-gupta
Copy link

Ref #138
Adds support for Timestamp()

@kanha-gupta
Copy link
Author

Hey @fpetkovski , Please review this.
engine_test.go tests are failing & I am not able to figure out why.
I request for your guidance :)

@yeya24
Copy link
Contributor

yeya24 commented Jul 29, 2023

Regarding #206 (comment), this seems incorrect. We shouldn't return the step time.

@kanha-gupta
Copy link
Author

@yeya24 Okay, thank you for mentioning. I am closing the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants