*: rm ZLabels #7675
Merged
*: rm ZLabels #7675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiedriusS
force-pushed
the
add_grpc_pooling
branch
2 times, most recently
from
062c2f1
to
20fe684
Compare
Add pooling for grpc requests/responses. Signed-off-by: Giedrius Statkevičius <[email protected]>
GiedriusS
force-pushed
the
add_grpc_pooling
branch
from
20fe684
to
5d4c3e1
Compare
Signed-off-by: Giedrius Statkevičius <[email protected]>
GiedriusS
force-pushed
the
add_grpc_pooling
branch
from
e11fd06
to
c03f4fe
Compare
Signed-off-by: Giedrius Statkevičius <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>
GiedriusS
force-pushed
the
add_grpc_pooling
branch
from
08dcdea
to
042c37c
Compare
Signed-off-by: Giedrius Statkevičius <[email protected]>
GiedriusS
force-pushed
the
add_grpc_pooling
branch
3 times, most recently
from
590ad41
to
2254b97
Compare
Signed-off-by: Giedrius Statkevičius <[email protected]>
GiedriusS
force-pushed
the
add_grpc_pooling
branch
from
2254b97
to
65a1275
Compare
MichaHoffmann
approved these changes
Sep 5, 2024
fpetkovski
approved these changes
Sep 5, 2024
GiedriusS
added a commit
that referenced
this pull request
Oct 1, 2024
This reverts commit 8c8a88e. Signed-off-by: Giedrius Statkevičius <[email protected]>
GiedriusS
added a commit
that referenced
this pull request
Oct 1, 2024
This reverts commit 8c8a88e. Signed-off-by: Giedrius Statkevičius <[email protected]>
GiedriusS
added a commit
that referenced
this pull request
Oct 1, 2024
This reverts commit 8c8a88e. Signed-off-by: Giedrius Statkevičius <[email protected]>
GiedriusS
added a commit
that referenced
this pull request
Oct 1, 2024
This reverts commit 8c8a88e. Signed-off-by: Giedrius Statkevičius <[email protected]>
GiedriusS
added a commit
that referenced
this pull request
Oct 1, 2024
* Revert "store: add chunk pooling (#7771)" This reverts commit a2113fd. Signed-off-by: Giedrius Statkevičius <[email protected]> * Revert "query/store: memoize PromLabels() call (#7767)" This reverts commit 735db72. Signed-off-by: Giedrius Statkevičius <[email protected]> * Revert "store: compare labels directly (#7766)" This reverts commit 30f453e. Signed-off-by: Giedrius Statkevičius <[email protected]> * Revert "store: don't create intermediate labels (#7762)" This reverts commit 8cd3fae. Signed-off-by: Giedrius Statkevičius <[email protected]> * Revert "*: build with stringlabels (#7745)" This reverts commit 883fade. Signed-off-by: Giedrius Statkevičius <[email protected]> * Revert "*: enable gRPC pooling (#7742)" This reverts commit ca8ab90. Signed-off-by: Giedrius Statkevičius <[email protected]> * Revert "*: switch to vtprotobuf (#7721)" This reverts commit a8e7109. Signed-off-by: Giedrius Statkevičius <[email protected]> * Revert "*: removing gogoproto extensions (#7718)" This reverts commit 97710f4. Signed-off-by: Giedrius Statkevičius <[email protected]> * Revert "*: rm ZLabels (#7675)" This reverts commit 8c8a88e. Signed-off-by: Giedrius Statkevičius <[email protected]> --------- Signed-off-by: Giedrius Statkevičius <[email protected]>
jnyi
pushed a commit
to jnyi/thanos
that referenced
this pull request
Oct 17, 2024
* server/grpc: add pooling Add pooling for grpc requests/responses. Signed-off-by: Giedrius Statkevičius <[email protected]> * *: rm ZLabels and friends Signed-off-by: Giedrius Statkevičius <[email protected]> * *: fix tests Signed-off-by: Giedrius Statkevičius <[email protected]> * go.mod: revert changes Signed-off-by: Giedrius Statkevičius <[email protected]> --------- Signed-off-by: Giedrius Statkevičius <[email protected]>
jnyi
pushed a commit
to jnyi/thanos
that referenced
this pull request
Oct 17, 2024
* Revert "store: add chunk pooling (thanos-io#7771)" This reverts commit a2113fd. Signed-off-by: Giedrius Statkevičius <[email protected]> * Revert "query/store: memoize PromLabels() call (thanos-io#7767)" This reverts commit 735db72. Signed-off-by: Giedrius Statkevičius <[email protected]> * Revert "store: compare labels directly (thanos-io#7766)" This reverts commit 30f453e. Signed-off-by: Giedrius Statkevičius <[email protected]> * Revert "store: don't create intermediate labels (thanos-io#7762)" This reverts commit 8cd3fae. Signed-off-by: Giedrius Statkevičius <[email protected]> * Revert "*: build with stringlabels (thanos-io#7745)" This reverts commit 883fade. Signed-off-by: Giedrius Statkevičius <[email protected]> * Revert "*: enable gRPC pooling (thanos-io#7742)" This reverts commit ca8ab90. Signed-off-by: Giedrius Statkevičius <[email protected]> * Revert "*: switch to vtprotobuf (thanos-io#7721)" This reverts commit a8e7109. Signed-off-by: Giedrius Statkevičius <[email protected]> * Revert "*: removing gogoproto extensions (thanos-io#7718)" This reverts commit 97710f4. Signed-off-by: Giedrius Statkevičius <[email protected]> * Revert "*: rm ZLabels (thanos-io#7675)" This reverts commit 8c8a88e. Signed-off-by: Giedrius Statkevičius <[email protected]> --------- Signed-off-by: Giedrius Statkevičius <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to get rid of ZLabels and friends because those assume that the underlying []byte doesn't get reused. gRPC recently added support for pooling. It's about time we optimize this part. Good time to push this over the line. This has been a WIP for ~ 2 years.