query, rule: make endpoint discovery dynamically reloadable #7890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaHoffmann
force-pushed
the
mhoffmann/make-endpoint-config-dynamically-reloadable
branch
3 times, most recently
from
7b8c118 to
249620c
Compare
saswatamcode
reviewed
Nov 8, 2024
GiedriusS
reviewed
Nov 8, 2024
GiedriusS
reviewed
Nov 8, 2024
GiedriusS
reviewed
Nov 8, 2024
MichaHoffmann
force-pushed
the
mhoffmann/make-endpoint-config-dynamically-reloadable
branch
8 times, most recently
from
e57969b to
963126d
Compare
MichaHoffmann
force-pushed
the
mhoffmann/make-endpoint-config-dynamically-reloadable
branch
5 times, most recently
from
d5cfc49 to
e9f1ff4
Compare
MichaHoffmann
force-pushed
the
mhoffmann/make-endpoint-config-dynamically-reloadable
branch
5 times, most recently
from
12a9008 to
529954c
Compare
GiedriusS
reviewed
Nov 13, 2024
GiedriusS
reviewed
Nov 13, 2024
GiedriusS
reviewed
Nov 13, 2024
GiedriusS
reviewed
Nov 13, 2024
GiedriusS
reviewed
Nov 13, 2024
GiedriusS
reviewed
Nov 13, 2024
GiedriusS
reviewed
Nov 13, 2024
GiedriusS
reviewed
Nov 13, 2024
yeya24
reviewed
Nov 13, 2024
MichaHoffmann
force-pushed
the
mhoffmann/make-endpoint-config-dynamically-reloadable
branch
from
3284e0d to
a45ffad
Compare
MichaHoffmann
dismissed stale reviews from fpetkovski and saswatamcode
via
c7dd843
MichaHoffmann
force-pushed
the
mhoffmann/make-endpoint-config-dynamically-reloadable
branch
from
a45ffad to
c7dd843
Compare
MichaHoffmann
force-pushed
the
mhoffmann/make-endpoint-config-dynamically-reloadable
branch
5 times, most recently
from
46475aa to
a14056f
Compare
MichaHoffmann
force-pushed
the
mhoffmann/make-endpoint-config-dynamically-reloadable
branch
2 times, most recently
from
38dc0ac to
ee6f13b
Compare
GiedriusS
previously approved these changes
Jan 7, 2025
MichaHoffmann
force-pushed
the
mhoffmann/make-endpoint-config-dynamically-reloadable
branch
from
ee6f13b to
bfd9ae6
Compare
* Removed previously deprecated and hidden flags to configure endpoints ( --rule, --target, ...) * Added new flags --endpoint.sd-config, --endpoint-sd-config-reload-interval to configure a dynamic SD file * Moved endpoint set construction into cmd/thanos/endpointset.go for a little cleanup * Renamed "thanos_(querier/ruler)_duplicated_store_addresses_total" to "thanos_(querier/ruler)_duplicated_endpoint_addresses_total" The new config makes it possible to also set "strict" and "group" flags on the endpoint instead of only their addresses, making it possible to have file based service discovery for endpoint groups too. Signed-off-by: Michael Hoffmann <[email protected]> Signed-off-by: Michael Hoffmann <[email protected]>
MichaHoffmann
force-pushed
the
mhoffmann/make-endpoint-config-dynamically-reloadable
branch
from
bfd9ae6 to
2455ab1
Compare
GiedriusS
approved these changes
Jan 15, 2025
GiedriusS
deleted the
mhoffmann/make-endpoint-config-dynamically-reloadable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
--store.sd-fileand--store.sd-intervalflags--endpoint.sd-config,--endpoint-sd-config-reload-intervalto configure a dynamic SD fileThe new config makes it possible to also set "strict" and "group" flags on the endpoint instead of only their addresses, making it possible to have file based service discovery for endpoint groups too.
Verification
Existing E2E test suite, some manual testing.