Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic Windows support using Rhino engine #47

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

chrisnash
Copy link

This pull request aims to get the current envjs to function from the command-line using the included Rhino platform. Three basic changes:

  • "file:" URL formatting corrected (taken from the first two commits in moschel's pull request Fixing filesystem paths in Envjs.uri #23 ).
  • simple envjs.bat and debug.bat in the bin folder to launch under Rhino.
  • bug fix (should apply to any Rhino instance, not just Windows) in Envjs.localXHR. Pattern matching was being performed on the URL in order to determine a content type, but when running under Rhino the URL parameter is a java.net.URL, not a string.

Basic envjs example (for example a simple test.html file, window.location="test.html"; in test.js, then "bin\envjs test.js") works on Windows after these three changes.

moschel and others added 3 commits April 17, 2012 19:31
pull request thatcher#23, 031b304/b645a70 from moschel. Added Windows batch
files to run envjs using either Rhino or the Rhino debugger. Fixed
an issue in xhr.js Envjs.localXHR when running under Rhino, url
parameter was tested for pattern match to determine Content-Type,
but fails under Rhino since the url parameter passed is a Java
object, not a string.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants