Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add git reset button #109

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dserv-nh
Copy link

Partially resolves #106

@thathoff
Copy link
Owner

thathoff commented Jul 1, 2024

Hi, thanks for your pull request. Did you plan to implement a hard reset to the remote branch? Currently from my point of view it just discards all uncommitted local changes (which is exactly what the “Revert Changes“ button in the “Uncommitted changes” section does.

In addition I have a couple of questions and remarks:

  • The icon seems to be broken as reset-left is not in the standard icon set of Kirby
  • The button deletes data without user confirmation it should be implemented like the other buttons with a confirmation dialog. In this case you event don’t need an API route.

@dserv-nh dserv-nh marked this pull request as draft July 2, 2024 07:55
@dserv-nh
Copy link
Author

dserv-nh commented Jul 2, 2024

Thanks for your feedback. I didn't know about the "Revert Changes" button yet. This was just my first try and I couldn't test it. I need to set up a Kirby dev environment.
As for the icon I thought I could use any icon from the Remix icons, that's why I went for reset-left
Will probably update this in the coming weeks and also add more features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add buttons to revert/drop commits
2 participants