Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config for simps #3104

Merged
merged 2 commits into from
Jul 10, 2020
Merged

Update config for simps #3104

merged 2 commits into from
Jul 10, 2020

Conversation

sy-records
Copy link
Member

Hi, @waghanza Can you test it for me?

@waghanza
Copy link
Collaborator

waghanza commented Jul 7, 2020

Nice improvement

Could you please make the same for all swoole based frameworks ?

Language Framework Speed (64) Speed (256) Speed (512)
Before php (7.4) simps (1.0) 120 776 155 576 177 734
After php (7.4) simps (1.0) 108 843 170 021 188 892

@sy-records
Copy link
Member Author

Not necessarily applicable to all Swoole frameworks 🤣

@waghanza
Copy link
Collaborator

waghanza commented Jul 7, 2020

  • tcp_fastopen
  • enable_reuse_port

are not swoole options ?

@sy-records
Copy link
Member Author

It is a configuration of swoole, but not necessarily useful for other frameworks, I'm not sure.

Merge it later and I'll try to test it again.

@waghanza
Copy link
Collaborator

waghanza commented Jul 7, 2020

Ok. If you have no time to do so, I think I will try later 😛

My purpose is to keep (try to) same behaviours for different swoole based framework, I mean having as-far-as possible comparison

@sy-records
Copy link
Member Author

What is the linux kernel of the test environment? @waghanza

@sy-records
Copy link
Member Author

Can you run again?

@waghanza
Copy link
Collaborator

waghanza commented Jul 7, 2020

What is the linux kernel of the test environment?

5.7, I use the same distro than for cloud => fedora

Can you run again?

No. I'm not on a computer. But I can help you 😝

@sy-records
Copy link
Member Author

Well, you can run it when you have time.

@sy-records
Copy link
Member Author

Hi, @waghanza Do you have time now? Can you run again?

@waghanza
Copy link
Collaborator

waghanza commented Jul 8, 2020

Since my daughter is born I have time @sy-records 😛

I find :

Language Framework Speed (64) Speed (256) Speed (512)
Before (master) php (7.4) simps (1.0) 104 286 144 225 165 106
After (this branch) php (7.4) simps (1.0) 108 460 169 109 188 488

@sy-records
Copy link
Member Author

Congratulate you on becoming a father. 😆

These configuration items seem to have little effect, and the results of each test are different...

@waghanza
Copy link
Collaborator

waghanza commented Jul 9, 2020

Congratulate you on becoming a father. laughing

I'm already one, but I've lost my skills 😉 btw, thanks

These configuration items seem to have little effect, and the results of each test are different.

Due to docker ... There is too much fluctuations to consider something I suggest to wait for the cloud version to test this 😚 or if you have an other idea ....

@sy-records
Copy link
Member Author

When can you use the cloud version for testing?

The results is using a cloud version, right? You can also merge first, I can wait for the results to be updated. :)

@waghanza
Copy link
Collaborator

waghanza commented Jul 9, 2020

When can you use the cloud version for testing?

I don't know, it depends on my own schedule, and as you may know, this is not my top priority, right now

Their is no cloud results published for now, take a look at the roadmap #3108

@sy-records
Copy link
Member Author

#3068 (comment) In this comment, I thought you had used the cloud...

Is it still running in a docker environment?

@waghanza
Copy link
Collaborator

Yes. Cloud is not yet ready ...

laravel has too many files, dart is failing ... are some issues on cloud but I think I'll publish a cloud version in September

I'm still running in docker as for now. I can try to generate docker based results, along podman, but I think it will have the same issue

@sy-records
Copy link
Member Author

Okay, let's merge.

@waghanza waghanza merged commit 1493beb into the-benchmarker:master Jul 10, 2020
@sy-records sy-records deleted the patch-1 branch July 10, 2020 20:55
waghanza pushed a commit that referenced this pull request Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants