[PHP] Antidot: fix dependency issues in composer json #4571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpicaza
changed the title
kpicaza
changed the title
waghanza
reviewed
Aug 22, 2021
| @@ -13,13 +13,12 @@ | |||
| "ext-json": "*", | |||
| "antidot-fw/framework": "~0.2.1", | |||
| "antidot-fw/antidot-react-psr15": "*", | |||
| "antidot-fw/cli": "*", | |||
| "antidot-fw/cli": "^1.1", | |||
There was a problem hiding this comment.
might the keyword @stable could work ?
|
Sorry @waghanza, I'm debugging in more depth because the server falls after some stress tests, If you don't mind I prefer to check better the issue before merging, and for the moment moving the PR to draft, sorry for the inconvenience.
|
|
I think the issue is related to keep-alive connections on React HTTP server as described here reactphp/http#405 (comment). As a workaround, I will keep the react/http version fixed to v1.2.0. The performance is 2x better after v1.3.0, from 20k to 40k in Antidot Framework. But after some WRK hits the server crashes;-(.
|
waghanza
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @waghanza, I see that there is some issue running Antidot Framework inner the benchmark.
I updated the composer.json file to get at least the minimum required versions.
Thanks for your great work and for maintaining this excellent project;-D