-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Home page and logged out page styling #122
Conversation
1a85905
to
caa3ea4
Compare
Visit the preview URL for this PR (updated for commit e1fa143): https://tcl-67-smart-shopping-list--pr122-feature-home-page-st-yg4ou1so.web.app (expires Fri, 12 Apr 2024 20:50:03 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 1dc6f6876568bd8a1c97781eec7984835c207f7c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mentioned this in our channel. Since we haven't done a lot of CSS in this cohort there hasn't been an opportunity to bring this up. But components and css should be isolated together. Having global css files with changes can cause all kinds of issues and generally speaking most companies are not using files like these anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're missing the black borders on mobile screen size, homepage view
8c37eb9
to
c2131a2
Compare
Hey @aberger3647 and @flbarfield , I made the following changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome. Thanks for updating the border and breaking out the CSS files
bf27a3b
to
e1fa143
Compare
For an example of how to fill this template out, see this Pull Request.
Description
Updates to home page and logged out page styling according to high fidelity mockups. Also changed name to clevercart and implemented colors.
Related Issue
closes #121
closes #107
closes #105
Acceptance Criteria
Type of Changes
Styling update
Updates
Before
Mobile:


web:


After
Mobile:


Web:


Testing Steps / QA Criteria