Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home page and logged out page styling #122

Merged
merged 7 commits into from
Apr 5, 2024
Merged

Conversation

jtkabenni
Copy link
Collaborator

@jtkabenni jtkabenni commented Apr 4, 2024

For an example of how to fill this template out, see this Pull Request.

Description

Updates to home page and logged out page styling according to high fidelity mockups. Also changed name to clevercart and implemented colors.

Related Issue

closes #121
closes #107
closes #105

Acceptance Criteria

Type of Changes

Styling update

Updates

Before

Mobile:
Screenshot 2024-04-04 at 1 40 23 PM
Screenshot 2024-04-04 at 1 40 18 PM

web:
Screenshot 2024-04-04 at 1 40 11 PM
Screenshot 2024-04-04 at 1 40 03 PM

After

Mobile:
Screenshot 2024-04-04 at 1 38 27 PM
Screenshot 2024-04-04 at 1 38 15 PM

Web:
Screenshot 2024-04-04 at 1 39 18 PM
Screenshot 2024-04-04 at 1 39 28 PM

Testing Steps / QA Criteria

  • View logged out page
  • View mobile logged out page
  • Log in
  • View home page
  • View mobile home page

@jtkabenni jtkabenni force-pushed the feature/home-page-styling branch from 1a85905 to caa3ea4 Compare April 4, 2024 19:54
Copy link

github-actions bot commented Apr 4, 2024

Visit the preview URL for this PR (updated for commit e1fa143):

https://tcl-67-smart-shopping-list--pr122-feature-home-page-st-yg4ou1so.web.app

(expires Fri, 12 Apr 2024 20:50:03 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1dc6f6876568bd8a1c97781eec7984835c207f7c

@flbarfield
Copy link
Collaborator

flbarfield commented Apr 4, 2024

It's looking so goooood!!!!

I'm noticing some wonk with the input boxes and text on the login screen, though, at certain widths

Ex1 ex2

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mentioned this in our channel. Since we haven't done a lot of CSS in this cohort there hasn't been an opportunity to bring this up. But components and css should be isolated together. Having global css files with changes can cause all kinds of issues and generally speaking most companies are not using files like these anymore.

Copy link
Collaborator

@aberger3647 aberger3647 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're missing the black borders on mobile screen size, homepage view

@jtkabenni jtkabenni force-pushed the feature/home-page-styling branch from 8c37eb9 to c2131a2 Compare April 5, 2024 05:35
@jtkabenni
Copy link
Collaborator Author

Hey @aberger3647 and @flbarfield , I made the following changes:

  • created separate css files for AddListForm, LoggedOut, SelectListForm, and removed those styles from index.css
  • changed the sizing of all the headers in web (you will have to adjust the headers list view according to what looks right)
  • added an image for the logged out page image. @aberger3647 if you want to try to create it in css please feel free to.
  • updated our app name to clevercart
  • added borders where needed and removed it in some other places so they wouldn't double up

@jtkabenni jtkabenni requested a review from aberger3647 April 5, 2024 05:46
Copy link
Collaborator

@aberger3647 aberger3647 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome. Thanks for updating the border and breaking out the CSS files

@jtkabenni jtkabenni force-pushed the feature/home-page-styling branch from bf27a3b to e1fa143 Compare April 5, 2024 20:48
@jtkabenni jtkabenni merged commit ca13b84 into main Apr 5, 2024
3 checks passed
@flbarfield flbarfield deleted the feature/home-page-styling branch April 6, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement high fidelity styling to home page Finish Logged Out page Add "Welcome, {name}" to home page
4 participants