Added NavLink routing to layout. #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 8cf6c70): https://tcl-68-smart-shopping-list--pr17-ap-dg-navlink-routin-cwa3b2p6.web.app (expires Wed, 14 Feb 2024 02:40:39 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 8cb5d089a99ba9972009993f4dd31796b0cbda84 |
|
Great, I'll pass it on to our mentors to review before we merge the PR. |
cafloyd
reviewed
Feb 7, 2024
Removed completed TODO comment from Layout.jsx
cafloyd
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
Great work @andiedoescode and @DevinaG007 !! Well done with your first issue and PR!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the navigation links to use the
<NavLink>element from React Router to fix link functionality.Related Issue
closes #3
Acceptance Criteria
navelement is added to theLayoutcomponentnavelementNavLinkcomponent fromreact-router-domType of Changes
Code RefactoringUpdates
Before
Not a UI feature, before and after screenshots are not included.
After
Not a UI feature, before and after screenshots are not included.
Testing Steps / QA Criteria
Clicking Home leads to homepage
Clicking List leads to list page
Clicking Manage List leads to manage-list page