-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Home Page Styling #61
Conversation
Visit the preview URL for this PR (updated for commit f8b1436): https://tcl-68-smart-shopping-list--pr61-dg-sm-home-page-styl-rvsk9lr0.web.app (expires Thu, 11 Apr 2024 01:38:28 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 8cb5d089a99ba9972009993f4dd31796b0cbda84 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks as expected like the screenshots.
Nit (non-blocking): Sign in button is super wide in desktop view. I know we're focusing on the mobile view so this is not a priority.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay, looking good! A couple of minor/low-priority comments that I think we can do without for now if we run out of time.
…ab-lab/tcl-68-smart-shopping-list into dg-sm-home-page-styling
This reverts commit 6b38a92.
Description
Styled the home page of our shopping list app
Related Issue
closes #56
Acceptance Criteria
The following components should be styled according to our prototype:
Button
: Sign InInput Text Box
: Add new listLabel
: Add new listButton
: Create listList Items
: User's listsType of Changes
Enhancement
Updates
Before
After
Testing Steps / QA Criteria