Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Styling fixes and standardization #65

Merged
merged 9 commits into from
Apr 7, 2024
Merged

Styling fixes and standardization #65

merged 9 commits into from
Apr 7, 2024

Conversation

andiedoescode
Copy link
Collaborator

Description

Fixed styling and implemented consistent styling.

Related Issue

Closes #64

Acceptance Criteria

  • Check and standardize across views and components as needed:
    • Page margins
    • Text color
    • Form input height, background color, font size
    • Button radius
  • Fix home page styling
    • Space next to logout
    • New list input location
    • Side margins

Type of Changes

style and fix

Updates

Before

Home view
image

List view
image

After

Home view
image

List view
image

Testing Steps / QA Criteria

  • Open deployment link or pull branch ap-styling-fix-and-standardization
  • Ensure that Home and List views match screenshots for styling.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 7, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 01edd8c):

https://tcl-68-smart-shopping-list--pr65-ap-styling-fix-and-s-jn7z3bja.web.app

(expires Sun, 14 Apr 2024 03:57:02 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 8cb5d089a99ba9972009993f4dd31796b0cbda84

@andiedoescode andiedoescode marked this pull request as ready for review April 7, 2024 03:27
DevinaG007
DevinaG007 approved these changes Apr 7, 2024
View reviewed changes
Copy link
Collaborator

@DevinaG007 DevinaG007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!! It looks so fresh, so clean ❤️ Thanks Andrea

sdmisra
sdmisra approved these changes Apr 7, 2024
View reviewed changes
Copy link
Collaborator

@sdmisra sdmisra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Praise: Thank you immensely for making these changes so last minute, you really addressed some huge issues that we were about to run into in the morning, especially with some of that text defaulting to white on our light background!

cafloyd
cafloyd approved these changes Apr 7, 2024
View reviewed changes
Copy link
Member

@cafloyd cafloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, @andiedoescode ! This kind of attention to detail makes such a huge difference, thanks for taking the initiative!

etiry
etiry approved these changes Apr 7, 2024
View reviewed changes
Copy link
Collaborator

@etiry etiry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this!!

@sdmisra sdmisra merged commit b414b29 into main Apr 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etiry etiry etiry approved these changes

@cafloyd cafloyd cafloyd approved these changes

@sdmisra sdmisra sdmisra approved these changes

@DevinaG007 DevinaG007 DevinaG007 approved these changes

@luisaugusto luisaugusto Awaiting requested review from luisaugusto

@raaynaldo raaynaldo Awaiting requested review from raaynaldo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Styling fixes and standardization
5 participants
@andiedoescode @etiry @cafloyd @sdmisra @DevinaG007