Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website for UPMC, UPMC-Central PA, Wellspan #283

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

BenjaminatEpic
Copy link
Contributor

Grouped because they all failed the current checks. I don't believe they were failing the new tests in the CORS Headers PR.

Grouped because they all failed the current checks. I don't believe they were failing the new tests in the CORS Headers PR.
@BenjaminatEpic BenjaminatEpic changed the title website for UPMC, UPMC-PA, Wellspan website for UPMC, UPMC-Central PA, Wellspan Nov 4, 2021
@@ -883,6 +883,7 @@
{
"iss": "https://interconnect.wellspan.org/interconnect-prd-fhir/api/epic/2021/Security/Open/EcKeys/32001/SHC",
"name": "WellSpan Health"
"website": "https://www.wellspan.org/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if this PR is still relevant, but you are missing a , on the line above, hence why the PR checks are failing (ditto on below changes to website)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes! Thanks for pointing that out! Unfortunately it doesn't look like that alone was enough to resolve the checks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like these iss values don't/no longer resolve to a valid JSON document constituting the signing key of an issuer. For instance, viewing https://interconnect.wellspan.org/interconnect-prd-fhir/api/epic/2021/Security/Open/EcKeys/32001/SHC/.well-known/jwks.json returns an XML document, which does not conform to the SHC spec. I would investigate from there!

Copy link
Contributor

@dleve123 dleve123 Dec 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I think my browser was just attempting to render as XML; curl-ing does show that it is in fact returning a JSON document, so don't believe that's the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants