security recommendations #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384 | ||
| * TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256 | ||
| * TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA384 | ||
| * TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA |
There was a problem hiding this comment.
Per discussion on zulip, I'd suggest dropping the ciphersuites ending in _SHA; good for backward compat, but since SHC is a new spec, using SHA-2 family is ok and recommended.
| * TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256 | ||
| * TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA | ||
| 1. Certificate expiration complies with the following: | ||
| * No certificate issued after July 1st, 2019, can have a total lifetime of more than 825 days |
There was a problem hiding this comment.
Why keep the post-2019 req? Are we expecting endpoints using old cert issued between 2019 and 2020?
There was a problem hiding this comment.
Hey Christian, yeah, definitely. For our particular vantage point, issuers are using existing infrastructure to host these endpoints in the vast majority of cases. (And existing certs wouldn't become invalid per ATS until 12/4/2022).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.