add issuer_type=network #867
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmandel
suggested changes
Oct 7, 2022
There was a problem hiding this comment.
Nice. I think this should work well. A few suggestions:
- Document explicitly that the elements of the
network_participantsneed to have have alabel,locations, andissuer_type(with the same meaning that these properties have on top-level entries) - Roll up the
locationsfrom thenetwork_participantsinto alocationson the top-level network, so existing "search by state" lookups will find networks (but keep them on the locations too, so future tools can tell which participants operate in which locations) - Revert JSON examples in both files to use spaces, not tabs.
|
i like this, thanks Isaac. i would suggest we add subtypes to the |
> Document explicitly that the elements of the network_participants need to have have a label, locations, and issuer_type (with the same meaning that these properties have on top-level entries) > Roll up the locations from the network_participants into a locations on the top-level network, so existing "search by state" lookups will find networks (but keep them on the locations too, so future tools can tell which participants operate in which locations) Note that I'm leaving location as optional for the network participant, just as it is on the issuer.
sw industry: discuss. (vim had it right)
also json no longer validates
jmandel
approved these changes
Oct 10, 2022
Co-authored-by: Josh Mandel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.