Change Draupnir['start'] to be synchronous.

src/Draupnir.ts

@@ -322,17 +322,17 @@ export class Draupnir implements Client, MatrixAdaptorContext {
    * This will not start the appservice from listening and responding
    * to events. Nor will it start any syncing client.
    */
-  public async start(): Promise<void> {
+  public start(): void {
     // to avoid handlers getting out of sync on clientRooms and leaking
     // when draupnir keeps being started and restarted, we can basically
     // clear all listeners each time and add the factory listener back.
     this.clientRooms.on("timeline", this.timelineEventListener);
     if (this.reportPoller) {
-      const reportPollSetting = await ReportPoller.getReportPollSetting(
+      // allow this to crash draupnir if it fails, since we need to know.
+      void this.reportPoller.startFromStoredSetting(
         this.client,
         this.managementRoomOutput
       );
-      this.reportPoller.start(reportPollSetting);
     }
   }
 

src/DraupnirBotMode.ts

@@ -184,7 +184,7 @@ export class DraupnirBotModeToggle implements BotModeTogle {
       return draupnirResult;
     }
     this.draupnir = draupnirResult.ok;
-    void Task(this.draupnir.start());
+    this.draupnir.start();
     if (options?.sendStatusOnStart) {
       void Task(this.draupnir.startupComplete());
       try {

src/draupnirfactory/StandardDraupnirManager.ts

@@ -8,12 +8,7 @@
 // https://github.com/matrix-org/mjolnir
 // </text>
 
-import {
-  ActionError,
-  ActionResult,
-  Task,
-  isError,
-} from "matrix-protection-suite";
+import { ActionError, ActionResult, isError } from "matrix-protection-suite";
 import { IConfig } from "../config";
 import { DraupnirFactory } from "./DraupnirFactory";
 import { Draupnir } from "../Draupnir";
@@ -88,7 +83,7 @@ export class StandardDraupnirManager {
     }
     this.draupnir.set(clientUserID, draupnir.ok);
     this.failedDraupnir.delete(clientUserID);
-    void Task(draupnir.ok.start());
+    draupnir.ok.start();
     return draupnir;
   }
 

src/report/ReportPoller.ts

@@ -207,6 +207,18 @@ export class ReportPoller {
     }
     return reportPollSetting;
   }
+
+  public async startFromStoredSetting(
+    client: MatrixSendClient,
+    managementRoomOutput: ManagementRoomOutput
+  ): Promise<void> {
+    const reportPollSetting = await ReportPoller.getReportPollSetting(
+      client,
+      managementRoomOutput
+    );
+    this.start(reportPollSetting);
+  }
+
   public start({ from: startFrom }: ReportPollSetting) {
     if (this.timeout === null) {
       this.from = startFrom;