Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to modern yarn with pnpm linking #562

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Mikaela
Copy link
Member

@Mikaela Mikaela commented Sep 16, 2024

yarn lint fails since ➤ YN0060: │ eslint is listed by your project with version 9.7.0 (p456fe), which doesn't satisfy what typescript-eslint and other dependencies request (^8.56.0). and I am unsure on whether that is something I am causing.

Resolves: #475

@TheArcaneBrony
Copy link
Contributor

I'm sure this'll stop exactly nobody but I have no idea how to deal with modern yarn under nix. As far as I can find, the only solution are ugly hacks, or shipping a package-lock.json for plain npm.

Ugly hacks are already in use to get draupnir to build with corepack: NixOS/nixpkgs#274052 (comment)

I would love to avoid a situation where I have to either choose to not use draupnir at all, or commit heinous crimes to patch all of this out to get it to compile at all.

@Mikaela
Copy link
Member Author

Mikaela commented Sep 16, 2024

Without the previous commit, which I think is wrong, the three errors are:

p15e0c → ✘ @typescript-eslint/utils@npm:7.16.1 [5bdff] doesn't provide typescript to @typescript-eslint/typescript-estree@npm:7.16.1 [394be] and 1 other dependency
p456fe → ✘ draupnir@workspace:. provides eslint@npm:9.7.0 to typescript-eslint@npm:7.16.1 [5cb8f] and 5 other dependencies
pc715b → ✘ draupnir@workspace:. doesn't provide matrix-bot-sdk to @gnuxie/matrix-protection-suite-for-matrix-bot-sdk@npm:1.3.0 [5cb8f]

I wonder if

@@ -69,6 +69,7 @@
"js-yaml": "^4.1.0",
"jsdom": "^24.0.0",
"matrix-appservice-bridge": "^9.0.1",
"matrix-bot-sdk": "^0.7.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did this get added?

@Gnuxie
Copy link
Member

Gnuxie commented Sep 16, 2024

pc715b → ✘ draupnir@workspace:. doesn't provide matrix-bot-sdk to @gnuxie/matrix-protection-suite-for-matrix-bot-sdk@npm:1.3.0 [5cb8f]

We use a new vector fork of the matrix-bot-sdk because of matrix-appservice-bridge, but depending on the version of matrix-appservice-bridge you use, they expect the vector fork to be aliased to "matrix-bot-sdk". The newer versions remove that alias.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to modern Yarn
3 participants