Initial safe mode (without editor or recovery options) #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Something that is going to be broken for sure are the guages on the appservice manager, since toggling is controlled by the base manager. I have no idea what these guages are even for except the legacy draupnir4all work.
Works, but safe mode isn't hooked up to respond to any events.
Currently integration tests will be broken because we took control over "who starts Draupnir?" away and gave it to the `SafeModeToggle`. So we need to fix that.
without disrupting e2ee.
Now we need to change the integration test's makeMjolnir do the same.
We need to look at Draupnir's .start method and make it `void`. The report poller should just throw if it fails without being caught by `Task`. We also need to test the `toggle` in appservice in integration tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: the-draupnir-project/planning#26
TODO: Gnuxie/matrix-protection-suite#62