Feat/et 2163 status notices #3210
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tec-bot
reviewed
Aug 29, 2024
Camwyn
previously approved these changes
Aug 29, 2024
dpanta94
requested changes
Aug 30, 2024
...ion/TEC/Admin/__snapshots__/Ticket_NoticesTest__messages_should_match with data set 0__1.php
Outdated
Show resolved
Hide resolved
dpanta94
previously approved these changes
Sep 3, 2024
…alendar/event-tickets into feat/ET-2163-status-notices
…com:the-events-calendar/event-tickets into feat/ET-2163-status-notices"" This reverts commit 2badbfa.
dpanta94
previously approved these changes
Sep 19, 2024
dpanta94
reviewed
Sep 19, 2024
bordoni
requested changes
Sep 23, 2024
| * | ||
| * @package TEC\Tickets\Commerce\Admin | ||
| */ | ||
| class Singular_Order_Notices { |
There was a problem hiding this comment.
I would love to chat tomorrow about this particular implementation before we merge, I have some thoughts on potentially using some other pattern that doesn't involve as many constants.
JPry
reviewed
Sep 23, 2024
Comment on lines
22
to
28
| /** | ||
| * @since TBD | ||
| * | ||
| * @var string Notice key. | ||
| */ | ||
| const ORDER_STATUS_SUCCESSFULLY_UPDATED = 'updated'; | ||
| /** |
There was a problem hiding this comment.
These all need a space between them.
Suggested change
| /** | |
| * @since TBD | |
| * | |
| * @var string Notice key. | |
| */ | |
| const ORDER_STATUS_SUCCESSFULLY_UPDATED = 'updated'; | |
| /** | |
| /** | |
| * @since TBD | |
| * | |
| * @var string Notice key. | |
| */ | |
| const ORDER_STATUS_SUCCESSFULLY_UPDATED = 'updated'; | |
| /** |
JPry
reviewed
Sep 23, 2024
| /** | ||
| * Success messages. | ||
| */ | ||
| /* translators: %1$s: order number. %2$s: status the order was changed from. %3$s: status the order was changed to. */ |
There was a problem hiding this comment.
For these comments, you don't need to include the extra characters in the placeholders.
Suggested change
| /* translators: %1$s: order number. %2$s: status the order was changed from. %3$s: status the order was changed to. */ | |
| /* translators: 1: order number 2: status the order was changed from 3: status the order was changed to. */ |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
ET-2163
🗒️ Description
Status notices.
🎥 Artifacts
✔️ Checklist
npm run changelogto add changelog file(s). More info herewpunitorintegrationtests.wpunitorintegrationtests.