Marketing Notices for Black Friday. #2225

bordoni · 2024-10-11T06:41:52Z

🎫 Ticket

ET-2241 TEC-5242

🗒️ Description

As you review this, please make sure you keep in mind this is for a Black Friday.

Still haven't touched the existing tests here, so I am expecting them to break, will fix them tomorrow.

🎥 Artifacts

https://i.bordoni.me/GqsJbYmj

--

Video update on Oct 14 with dismissal:
https://i.bordoni.me/XKC3GDY0

…ault.

… to ET

src/Common/Admin/Conditional_Content/Black_Friday.php

tec-bot

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

phpcs

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed

tribe-common/src/Common/Admin/Settings_Sidebar.php

Line 40 in 3800071

</div>

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed

tribe-common/src/Common/Admin/Settings_Sidebar.php

Line 43 in 3800071

</div>

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed

tribe-common/src/Common/Admin/Settings_Sidebar.php

Line 85 in 3800071

array_unshift( $this->sections, $section );

[phpcs] _{reported by reviewdog 🐶}
Squiz.Commenting.FunctionComment.InvalidReturnVoid
Function return type is void, but function contains return statement

tribe-common/src/Common/Admin/Settings_Sidebar_Section.php

Line 43 in 3800071

* @return void

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed

tribe-common/src/Common/Admin/Settings_Sidebar_Section.php

Line 84 in 3800071

* @return void

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed

tribe-common/src/Common/Admin/Settings_Sidebar_Section.php

Line 88 in 3800071

    
           <div class="tec-settings-form__sidebar-section tec-settings-form__sidebar-header">

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed

tribe-common/src/Common/Admin/Settings_Sidebar_Section.php

Line 89 in 3800071

<?php do_action( 'tec_settings_sidebar_header_start' ); ?>

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed

tribe-common/src/Common/Admin/Settings_Sidebar_Section.php

Line 90 in 3800071

<?php

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed

tribe-common/src/Common/Admin/Settings_Sidebar_Section.php

Line 91 in 3800071

$this->render_header_image();

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed

tribe-common/src/Common/Admin/Settings_Sidebar_Section.php

Line 92 in 3800071

$this->render_title();

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed

tribe-common/src/Common/Admin/Settings_Sidebar_Section.php

Line 93 in 3800071

?>

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed

tribe-common/src/Common/Admin/Settings_Sidebar_Section.php

Line 94 in 3800071

<?php do_action( 'tec_settings_sidebar_header_end' ); ?>

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed

tribe-common/src/Common/Admin/Settings_Sidebar_Section.php

Line 95 in 3800071

</div>

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed

tribe-common/src/Common/Admin/Settings_Sidebar_Section.php

Line 96 in 3800071

<?php foreach ( $this->sections as $section ) : ?>

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed

tribe-common/src/Common/Admin/Settings_Sidebar_Section.php

Line 97 in 3800071

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed

tribe-common/src/Common/Admin/Settings_Sidebar_Section.php

Line 98 in 3800071

<?php $section->render(); ?>

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed

tribe-common/src/Common/Admin/Settings_Sidebar_Section.php

Line 99 in 3800071

</div>

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed

tribe-common/src/Common/Admin/Settings_Sidebar_Section.php

Line 100 in 3800071

<?php endforeach; ?>

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed

tribe-common/src/admin-views/app-shop.php

Line 55 in 3800071

    
           <?php tribe( \TEC\Common\Admin\Conditional_Content\Black_Friday::class )->render_wide_banner_html(); ?>

[phpcs] _{reported by reviewdog 🐶}
WordPress.WP.GlobalVariablesOverride.Prohibited
Overriding WordPress globals is prohibited. Found assignment to $year

tribe-common/src/admin-views/conditional_content/black-friday.php

Line 11 in 3800071

$year = date_i18n( 'Y' );

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed

tribe-common/src/admin-views/conditional_content/black-friday.php

Line 16 in 3800071

href="<?php echo esc_url( $link ); ?>"

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed

tribe-common/src/admin-views/conditional_content/black-friday.php

Line 17 in 3800071

target="_blank"

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed

tribe-common/src/admin-views/conditional_content/black-friday.php

Line 18 in 3800071

rel="noopener nofollow"

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed

tribe-common/src/admin-views/conditional_content/black-friday.php

Line 19 in 3800071

    
           style="display: block; margin: 25px 0; <?php echo $this->get( 'is_narrow' ) ? 'max-width: 1000px' : ''; ?>"

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed

tribe-common/src/admin-views/conditional_content/black-friday.php

Line 20 in 3800071

    
           title="<?php echo sprintf( esc_attr_x( '%1$s Black Friday Sale for The Events Calendar plugins, add-ons and bundles.', 'Alt text for the Black Friday Ad', 'tribe-common' ), $year ); ?>"

[phpcs] _{reported by reviewdog 🐶}
Universal.CodeAnalysis.NoEchoSprintf.Found
Unnecessary "echo sprintf(...)" found. Use "printf(...)" instead.

tribe-common/src/admin-views/conditional_content/black-friday.php

Line 20 in 3800071

    
           title="<?php echo sprintf( esc_attr_x( '%1$s Black Friday Sale for The Events Calendar plugins, add-ons and bundles.', 'Alt text for the Black Friday Ad', 'tribe-common' ), $year ); ?>"

[phpcs] _{reported by reviewdog 🐶}
WordPress.WP.I18n.MissingTranslatorsComment
A function call to esc_attr_x() with texts containing placeholders was found, but was not accompanied by a "translators:" comment on the line above to clarify the meaning of the placeholders.

tribe-common/src/admin-views/conditional_content/black-friday.php

Line 20 in 3800071

    
           title="<?php echo sprintf( esc_attr_x( '%1$s Black Friday Sale for The Events Calendar plugins, add-ons and bundles.', 'Alt text for the Black Friday Ad', 'tribe-common' ), $year ); ?>"

[phpcs] _{reported by reviewdog 🐶}
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not '$year'

tribe-common/src/admin-views/conditional_content/black-friday.php

Line 20 in 3800071

    
           title="<?php echo sprintf( esc_attr_x( '%1$s Black Friday Sale for The Events Calendar plugins, add-ons and bundles.', 'Alt text for the Black Friday Ad', 'tribe-common' ), $year ); ?>"

[phpcs] _{reported by reviewdog 🐶}
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$year'.

tribe-common/src/admin-views/conditional_content/black-friday.php

Line 20 in 3800071

    
           title="<?php echo sprintf( esc_attr_x( '%1$s Black Friday Sale for The Events Calendar plugins, add-ons and bundles.', 'Alt text for the Black Friday Ad', 'tribe-common' ), $year ); ?>"

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed

tribe-common/src/admin-views/conditional_content/black-friday.php

Line 23 in 3800071

    
           style="display: block; width: 100%; height: auto;" <?php // This is intentionally inline, don't add classes here. ?>

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed

tribe-common/src/admin-views/conditional_content/black-friday.php

Line 24 in 3800071

src="<?php echo esc_url( $image_src ); ?>"

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed

tribe-common/src/admin-views/conditional_content/black-friday.php

Line 25 in 3800071

    
           alt="<?php echo sprintf( esc_attr_x( '%1$s Black Friday Sale for The Events Calendar plugins, add-ons and bundles.', 'Alt text for the Black Friday Ad', 'tribe-common' ), $year ); ?>"

[phpcs] _{reported by reviewdog 🐶}
Universal.CodeAnalysis.NoEchoSprintf.Found
Unnecessary "echo sprintf(...)" found. Use "printf(...)" instead.

tribe-common/src/admin-views/conditional_content/black-friday.php

Line 25 in 3800071

    
           alt="<?php echo sprintf( esc_attr_x( '%1$s Black Friday Sale for The Events Calendar plugins, add-ons and bundles.', 'Alt text for the Black Friday Ad', 'tribe-common' ), $year ); ?>"

[phpcs] _{reported by reviewdog 🐶}
WordPress.WP.I18n.MissingTranslatorsComment
A function call to esc_attr_x() with texts containing placeholders was found, but was not accompanied by a "translators:" comment on the line above to clarify the meaning of the placeholders.

tribe-common/src/admin-views/conditional_content/black-friday.php

Line 25 in 3800071

    
           alt="<?php echo sprintf( esc_attr_x( '%1$s Black Friday Sale for The Events Calendar plugins, add-ons and bundles.', 'Alt text for the Black Friday Ad', 'tribe-common' ), $year ); ?>"

[phpcs] _{reported by reviewdog 🐶}
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not '$year'

tribe-common/src/admin-views/conditional_content/black-friday.php

Line 25 in 3800071

    
           alt="<?php echo sprintf( esc_attr_x( '%1$s Black Friday Sale for The Events Calendar plugins, add-ons and bundles.', 'Alt text for the Black Friday Ad', 'tribe-common' ), $year ); ?>"

[phpcs] _{reported by reviewdog 🐶}
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$year'.

tribe-common/src/admin-views/conditional_content/black-friday.php

Line 25 in 3800071

    
           alt="<?php echo sprintf( esc_attr_x( '%1$s Black Friday Sale for The Events Calendar plugins, add-ons and bundles.', 'Alt text for the Black Friday Ad', 'tribe-common' ), $year ); ?>"

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed

tribe-common/src/admin-views/conditional_content/black-friday.php

Line 26 in 3800071

/>

src/Common/Admin/Conditional_Content/Black_Friday.php

src/Common/Admin/Entities/Link.php

tec-bot

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

phpcs

[phpcs] _{reported by reviewdog 🐶}
WordPress.WP.I18n.MissingTranslatorsComment
A function call to esc_attr_x() with texts containing placeholders was found, but was not accompanied by a "translators:" comment on the line above to clarify the meaning of the placeholders.

tribe-common/src/admin-views/conditional_content/black-friday.php

Line 25 in b8c45b6

    
           alt="<?php echo sprintf( esc_attr_x( '%1$s Black Friday Sale for The Events Calendar plugins, add-ons and bundles.', 'Alt text for the Black Friday Ad', 'tribe-common' ), $year ); ?>"

[phpcs] _{reported by reviewdog 🐶}
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not '$year'

tribe-common/src/admin-views/conditional_content/black-friday.php

Line 25 in b8c45b6

    
           alt="<?php echo sprintf( esc_attr_x( '%1$s Black Friday Sale for The Events Calendar plugins, add-ons and bundles.', 'Alt text for the Black Friday Ad', 'tribe-common' ), $year ); ?>"

[phpcs] _{reported by reviewdog 🐶}
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$year'.

tribe-common/src/admin-views/conditional_content/black-friday.php

Line 25 in b8c45b6

    
           alt="<?php echo sprintf( esc_attr_x( '%1$s Black Friday Sale for The Events Calendar plugins, add-ons and bundles.', 'Alt text for the Black Friday Ad', 'tribe-common' ), $year ); ?>"

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed

tribe-common/src/admin-views/conditional_content/black-friday.php

Line 26 in b8c45b6

/>

src/Common/Admin/Conditional_Content/Datetime_Conditional_Abstract.php

src/Tribe/Admin/Notice/Service_Provider.php

… checks

tec-bot · 2024-10-15T17:19:17Z

src/Common/Admin/Conditional_Content/Black_Friday.php

+			[
+				'style'                                       => 'position: absolute; top: 0; right: 0; background: transparent; border: 0; color: #fff; padding: 0.5em; cursor: pointer;',
+				'data-tec-conditional-content-dismiss-button' => true,
+				'data-tec-conditional-content-dismiss-slug'   => $this->slug,


[phpcs] _{reported by reviewdog 🐶}
WordPress.Arrays.MultipleStatementAlignment.LongIndexSpaceBeforeDoubleArrow
Expected 1 space between "'data-tec-conditional-content-dismiss-slug'" and double arrow; 3 found.

I've seen this too - apparently it breaks if one key is above some length. I haven't tested to find the "sweet spot"

JPry

The things I commented on before are looking good, with a few minor suggestions.

I made a few comments on some of the new stuff that was added, and most of it is also minor.

One thing I would also suggest for the Dismissible_Trait: I would recommend having some kind of validation method that handles common situations that would trigger a situation where we can't continue (like empty( $this->slug ) or empty( tribe_get_request_var( 'slug', false ) ), etc.). This method can throw an exception if there's an error, and silently pass if there's not an error. Then the calling code wraps that check in a try/catch block, and any exception just triggers the false response.

Let me know if you'd like to see an example of what I mean.

src/Common/Admin/Entities/Button.php

src/Common/Admin/Entities/Link.php

src/Common/Admin/Settings_Sidebar.php

src/Common/Admin/Settings_Sidebar_Section.php

src/Common/Admin/Conditional_Content/Dismissible_Trait.php

JPry · 2024-10-15T17:57:07Z

src/Common/Admin/Conditional_Content/Dismissible_Trait.php

+			return true;
+		}
+
+		update_user_meta( $user_id, $this->meta_key_time_prefix . $this->slug, time() );


Similar to how the nonce_action_prefix value is combined with slug, I think it would make sense to have a helper method to combine the two values and return the real meta key. Something like get_time_meta_key().

src/Common/Admin/Conditional_Content/Dismissible_Trait.php

Camwyn · 2024-10-15T17:52:11Z

changelog/deprecate-marketing-classes

@@ -0,0 +1,4 @@
+Significance: minor


Should there be another of these? This only covers the deprecations.

package.json

src/Common/Admin/Conditional_Content/Black_Friday.php

Camwyn · 2024-10-15T18:05:37Z

src/Common/Admin/Conditional_Content/Black_Friday.php

+			[
+				'style'                                       => 'position: absolute; top: 0; right: 0; background: transparent; border: 0; color: #fff; padding: 0.5em; cursor: pointer;',
+				'data-tec-conditional-content-dismiss-button' => true,
+				'data-tec-conditional-content-dismiss-slug'   => $this->slug,


I've seen this too - apparently it breaks if one key is above some length. I haven't tested to find the "sweet spot"

Camwyn · 2024-10-15T18:28:30Z

src/admin-views/conditional_content/black-friday.php

 */

+$year = date_i18n( 'Y' );


Use $sale_year if you care

src/admin-views/conditional_content/black-friday.php

src/resources/postcss/tribe-common-admin/settings/_sidebar.pcss

Co-authored-by: Stephen Page <[email protected]> Co-authored-by: Jeremy Pry <[email protected]>

src/Common/Admin/Conditional_Content/Dismissible_Trait.php

tec-bot

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

phpcs

[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed

tribe-common/src/Tribe/Admin/Notice/Service_Provider.php

Line 62 in c498e72

* @deprecated TBD

[phpcs] _{reported by reviewdog 🐶}
Squiz.Commenting.DocCommentAlignment.SpaceBeforeStar
Expected 1 space before asterisk; 5 found

tribe-common/src/Tribe/Admin/Notice/Service_Provider.php

Line 62 in c498e72

* @deprecated TBD

src/Common/Admin/Conditional_Content/Black_Friday.php

tec-bot · 2024-10-15T19:28:59Z

src/Common/Admin/Conditional_Content/Controller.php

+			return;
+		}
+
+		$this->container->singleton(  Black_Friday::class, Black_Friday::class, [ 'hook' ] );


[phpcs] _{reported by reviewdog 🐶}
PEAR.Functions.FunctionCallSignature.SpaceAfterOpenBracket
Expected 1 spaces after opening parenthesis; 2 found

Suggested change

$this->container->singleton( Black_Friday::class, Black_Friday::class, [ 'hook' ] );

$this->container->singleton( Black_Friday::class, Black_Friday::class, [ 'hook' ] );

tec-bot · 2024-10-15T19:28:59Z

src/Common/Admin/Conditional_Content/Datetime_Conditional_Abstract.php

@@ -0,0 +1,182 @@
+<?php


[phpcs] _{reported by reviewdog 🐶}
Squiz.Commenting.FileComment.Missing
Missing file doc comment

tec-bot · 2024-10-15T19:29:01Z

src/Tribe/Admin/Notice/Marketing/End_Of_Year_Sale.php

-
-		return $content;
+class End_Of_Year_Sale {
+	public function __call( $name, $arguments ) {


[phpcs] _{reported by reviewdog 🐶}
Squiz.Commenting.FunctionComment.Missing
Missing doc comment for function __call()

tec-bot · 2024-10-15T19:29:01Z

src/Tribe/Admin/Notice/Marketing/End_Of_Year_Sale.php

-		$date = $date->setTime( 23, 59 );
-
-		return $date;
+	public static function __callStatic( $name, $arguments ) {


[phpcs] _{reported by reviewdog 🐶}
Squiz.Commenting.FunctionComment.Missing
Missing doc comment for function __callStatic()

tec-bot · 2024-10-15T19:29:02Z

src/Tribe/Admin/Notice/Marketing/Stellar_Sale.php

-			}
-		}
+class Stellar_Sale {
+	public function __call( $name, $arguments ) {


[phpcs] _{reported by reviewdog 🐶}
Squiz.Commenting.FunctionComment.Missing
Missing doc comment for function __call()

tec-bot · 2024-10-15T19:29:02Z

src/Tribe/Admin/Notice/Marketing/Stellar_Sale.php


-		return $this->get_template()->template( 'notices/tribe-stellar-sale', $template_args, false );
+	public static function __callStatic( $name, $arguments ) {


[phpcs] _{reported by reviewdog 🐶}
Squiz.Commenting.FunctionComment.Missing
Missing doc comment for function __callStatic()

tec-bot · 2024-10-15T19:29:02Z

src/Tribe/Admin/Notice/Service_Provider.php

 	}

-	/**
+/**


[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.ScopeIndent.Incorrect
Line indented incorrectly; expected at least 1 tabs, found 0

Co-authored-by: Stephen Page <[email protected]>

tec-bot · 2024-10-15T19:35:59Z

src/Tribe/Admin/Notice/Service_Provider.php

 	 * This method is used to enqueue additional assets for the admin notices.
 	 * Each should conditionally call an internal `enqueue_additional_assets()` function to handle the enqueueing.
 	 *
 	 * @since 5.1.10
+     * @deprecated TBD


[phpcs] _{reported by reviewdog 🐶}
Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed

tec-bot · 2024-10-15T19:35:59Z

src/Tribe/Admin/Notice/Service_Provider.php

 	 * This method is used to enqueue additional assets for the admin notices.
 	 * Each should conditionally call an internal `enqueue_additional_assets()` function to handle the enqueueing.
 	 *
 	 * @since 5.1.10
+     * @deprecated TBD


[phpcs] _{reported by reviewdog 🐶}
Squiz.Commenting.DocCommentAlignment.SpaceBeforeStar
Expected 1 space before asterisk; 5 found

tec-bot · 2024-10-15T19:37:57Z

src/admin-views/conditional_content/black-friday.php

 */

+$sale_year = date_i18n( 'Y' );
+/* translators: %1$s: Black Friday year */


[phpcs] _{reported by reviewdog 🐶}
Squiz.Commenting.BlockComment.NoNewLine
Block comment text must start on a new line

tec-bot · 2024-10-15T20:35:05Z

src/Common/Admin/Conditional_Content/Black_Friday.php

+
+		$button_attr = new Attributes(
+			[
+				'style'                                       => 'position: absolute; top: 0; right: 0; background: transparent; border: 0; color: #fff; padding: 0.5em; cursor: pointer;',


[phpcs] _{reported by reviewdog 🐶}
WordPress.Arrays.MultipleStatementAlignment.DoubleArrowNotAligned
Array double arrow not aligned correctly; expected 1 space(s) between "'style'" and double arrow, but found 39.

tec-bot · 2024-10-15T20:35:05Z

src/Common/Admin/Conditional_Content/Black_Friday.php

+
+				// Dismiss button attributes.
+				'data-tec-conditional-content-dismiss-button' => true,
+				'data-tec-conditional-content-dismiss-slug'   => $this->slug,


[phpcs] _{reported by reviewdog 🐶}
WordPress.Arrays.MultipleStatementAlignment.LongIndexSpaceBeforeDoubleArrow
Expected 1 space between "'data-tec-conditional-content-dismiss-slug'" and double arrow; 3 found.

tec-bot · 2024-10-15T20:35:05Z

src/Common/Admin/Conditional_Content/Black_Friday.php

+				// Dismiss button attributes.
+				'data-tec-conditional-content-dismiss-button' => true,
+				'data-tec-conditional-content-dismiss-slug'   => $this->slug,
+				'data-tec-conditional-content-dismiss-nonce'  => $this->get_nonce(),


[phpcs] _{reported by reviewdog 🐶}
WordPress.Arrays.MultipleStatementAlignment.LongIndexSpaceBeforeDoubleArrow
Expected 1 space between "'data-tec-conditional-content-dismiss-nonce'" and double arrow; 2 found.

Marketing Notices for Black Friday.

bordoni added 9 commits October 10, 2024 16:43

Remove Marketing and Promo folder from images

834bc5c

Fully deprecate the Marketing Class

e163c74

Update Strauss version

bb50481

Fix one problem with changelogger

2ea5987

Clean bad files

798dbd8

Actually remove most of these classes. They are not being used by def…

6ffbb00

…ault.

Move some classes and remove unused notice templates

2955ac0

Simplify and prevent warning from removed methods

2790e31

Resolve all the edge-cases related to the types of banner and include…

3800071

… to ET

bordoni added the code review Status: requires a code review. label Oct 11, 2024

bordoni requested review from JPry, Camwyn and dpanta94 October 11, 2024 06:41

bordoni self-assigned this Oct 11, 2024

bordoni commented Oct 11, 2024

View reviewed changes

src/Common/Admin/Conditional_Content/Black_Friday.php Outdated Show resolved Hide resolved

tec-bot reviewed Oct 11, 2024

View reviewed changes

src/Common/Admin/Conditional_Content/Black_Friday.php Show resolved Hide resolved

src/Common/Admin/Entities/Link.php Outdated Show resolved Hide resolved

bordoni added 2 commits October 11, 2024 02:50

Fix some code sniffer problems

b8c45b6

Avoid spaces...

08efbc1

tec-bot reviewed Oct 11, 2024

View reviewed changes

Docblock

2740084

the-events-calendar deleted a comment from tec-bot Oct 11, 2024

bordoni added 2 commits October 11, 2024 02:56

Tabs, PHPStorm unlearned how to auto convert now...

4201ac5

Tabs, PHPStorm unlearned how to auto convert now...

21c009d

dpanta94 reviewed Oct 11, 2024

View reviewed changes

src/Common/Admin/Conditional_Content/Datetime_Conditional_Abstract.php Show resolved Hide resolved

src/Tribe/Admin/Notice/Service_Provider.php Show resolved Hide resolved

bordoni added 4 commits October 11, 2024 08:34

Fix the should display to ensure we have the correct filters/constant…

11ea932

… checks

Ignore one more docblock print

65a55c2

Fix some translations Code Sniff

55d63fb

Fix some translations Code Sniff

a4b1b4d

bordoni added 4 commits October 14, 2024 23:42

Clean up the Link entity

afcde72

Modify dates and remove forced conditional

189ce37

Resolve problems with Code Standards

6cc1963

Improve translation usage

5c9c8ce

tec-bot reviewed Oct 15, 2024

View reviewed changes

Spacing

ce54952

JPry requested changes Oct 15, 2024

View reviewed changes

Camwyn requested changes Oct 15, 2024

View reviewed changes

bordoni and others added 2 commits October 15, 2024 14:37

Use slug on the check

95d8431

Apply suggestions from code review

4fb9615

Co-authored-by: Stephen Page <[email protected]> Co-authored-by: Jeremy Pry <[email protected]>

tec-bot reviewed Oct 15, 2024

View reviewed changes

src/Common/Admin/Conditional_Content/Dismissible_Trait.php Outdated Show resolved Hide resolved

src/Common/Admin/Conditional_Content/Dismissible_Trait.php Outdated Show resolved Hide resolved

bordoni added 2 commits October 15, 2024 15:27

Re-include deprecated classes properly.

e6182b4

Re-include deprecated classes properly.

c498e72

tec-bot reviewed Oct 15, 2024

View reviewed changes

bordoni and others added 3 commits October 15, 2024 15:35

Apply suggestions from code review

110cc02

Co-authored-by: Stephen Page <[email protected]>

Last few changes

7c6cf49

Last few changes from code reviews

3edd0e2

tec-bot reviewed Oct 15, 2024

View reviewed changes

Remove slug to avoid complications

027f5c0

Camwyn previously approved these changes Oct 15, 2024

View reviewed changes

Fixes Mobile sidebar for settings and resolve last conflicts

95d8f9a

bordoni dismissed Camwyn’s stale review via 95d8f9a October 15, 2024 20:30

Camwyn previously approved these changes Oct 15, 2024

View reviewed changes

Remove the always displayh

65c5f20

bordoni dismissed Camwyn’s stale review via 65c5f20 October 15, 2024 20:34

tec-bot reviewed Oct 15, 2024

View reviewed changes

bordoni merged commit 26a91dc into release/T24.ettin Oct 15, 2024
11 of 17 checks passed

bordoni deleted the fix/marketing-notices branch October 15, 2024 20:35

Camwyn pushed a commit that referenced this pull request Oct 16, 2024

Merge pull request #2225 from the-events-calendar/fix/marketing-notices

7723942

Marketing Notices for Black Friday.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Marketing Notices for Black Friday. #2225

Marketing Notices for Black Friday. #2225

bordoni commented Oct 11, 2024 •

edited

Loading

tec-bot left a comment

tec-bot left a comment

tec-bot Oct 15, 2024

Camwyn Oct 15, 2024

JPry left a comment

JPry Oct 15, 2024

Camwyn Oct 15, 2024

Camwyn Oct 15, 2024

Camwyn Oct 15, 2024

tec-bot left a comment

tec-bot Oct 15, 2024

Camwyn Oct 15, 2024

tec-bot Oct 15, 2024

tec-bot Oct 15, 2024

tec-bot Oct 15, 2024

tec-bot Oct 15, 2024

tec-bot Oct 15, 2024

tec-bot Oct 15, 2024

tec-bot Oct 15, 2024

tec-bot Oct 15, 2024

tec-bot Oct 15, 2024

tec-bot Oct 15, 2024

tec-bot Oct 15, 2024

tec-bot Oct 15, 2024

	$this->container->singleton( Black_Friday::class, Black_Friday::class, [ 'hook' ] );
	$this->container->singleton( Black_Friday::class, Black_Friday::class, [ 'hook' ] );


		return $this->get_template()->template( 'notices/tribe-stellar-sale', $template_args, false );
		public static function __callStatic( $name, $arguments ) {

               	}
-              	/**
+              /**

Marketing Notices for Black Friday. #2225

Marketing Notices for Black Friday. #2225

Conversation

bordoni commented Oct 11, 2024 • edited Loading

🎫 Ticket

🗒️ Description

🎥 Artifacts

tec-bot left a comment

Choose a reason for hiding this comment

tec-bot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JPry left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tec-bot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bordoni commented Oct 11, 2024 •

edited

Loading