Include a way to get request variables without sanatization #2232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpanta94
requested changes
Oct 22, 2024
There was a problem hiding this comment.
The code is good. I would prefer seeing another method though tribe_get_request_var_raw which would be used inside tribe_get_request_var, rather than a new parameter.
In most cases where we want a get param to check its value, we want to use the tribe_get_request_var_raw, if what we want to get needs to be saved or displayed we need tribe_get_request_var :D
dpanta94
reviewed
Oct 22, 2024
Co-authored-by: Dimitrios Pantazis <[email protected]>
dpanta94
previously approved these changes
Oct 22, 2024
Camwyn
requested changes
Oct 22, 2024
src/functions/utils.php
Outdated
| } | ||
|
|
||
| if ( isset( $_POST ) ) { | ||
| $requests[] = (array) $_POST; | ||
| $requests[] = (array) $_POST; // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Recommended |
There was a problem hiding this comment.
Just disable at the beginning of the function and re-enable at the end?
i.e
function tribe_get_request_var_raw() {
// phpcs:disable
...
// phpcs:enable
}
(can be specific or not here)
dpanta94
previously approved these changes
Oct 22, 2024
Co-authored-by: Stephen Page <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
TEC-5283
🗒️ Description
Resolves the problem where because we are using
tribe_get_request_varit will strip all HTML.📹 Artifact
https://i.bordoni.me/Zt3Zk5Bd