Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master into bucket/order_modifiers_coupons_fees #2245

Open
wants to merge 167 commits into
base: bucket/order_modifiers_coupon_fees
Choose a base branch
from

Conversation

JPry
Copy link
Contributor

@JPry JPry commented Oct 31, 2024

🎫 Ticket

[TICKET_ID]

πŸ—’οΈ Description

πŸŽ₯ Artifacts

βœ”οΈ Checklist

  • Ran npm run changelog to add changelog file(s). More info here
  • Code is covered by NEW wpunit or integration tests.
  • Code is covered by EXISTING wpunit or integration tests.
  • Are all the required tests passing?
  • Automated code review comments are addressed.
  • Have you added Artifacts?
  • Check the base branch for your PR.
  • Add your PR to the project board for the release.

lucatume and others added 30 commits June 6, 2024 10:19
This adds the stellarwp/uplink library and configures it.
Camwyn and others added 27 commits October 16, 2024 13:08
…elease/T24.fetch-a8ffa18

Version bump for release/T24.fetch
…emote 'templates/actions/process-changelog/action.yml'
…aster

πŸ”„ synced file(s) with the-events-calendar/actions
…aster

πŸ”„ synced file(s) with the-events-calendar/actions
…aster

πŸ”„ synced file(s) with the-events-calendar/actions
…ate-for-fetch

Amend Release date for fetch
@JPry JPry self-assigned this Oct 31, 2024
Copy link
Contributor

@tec-bot tec-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

phpcs

[phpcs] reported by reviewdog 🐢
Squiz.Commenting.FunctionComment.Missing
Missing doc comment for function __callStatic()

public static function __callStatic( $name, $arguments ) {


[phpcs] reported by reviewdog 🐢
Generic.WhiteSpace.ScopeIndent.Incorrect
Line indented incorrectly; expected at least 1 tabs, found 0


[phpcs] reported by reviewdog 🐢
Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed


[phpcs] reported by reviewdog 🐢
Squiz.Commenting.DocCommentAlignment.SpaceBeforeStar
Expected 1 space before asterisk; 5 found


[phpcs] reported by reviewdog 🐢
WordPress.Arrays.MultipleStatementAlignment.DoubleArrowNotAligned
Array double arrow not aligned correctly; expected 2 space(s) between "'href'" and double arrow, but found 1.

'href' => [],


[phpcs] reported by reviewdog 🐢
WordPress.Arrays.MultipleStatementAlignment.DoubleArrowNotAligned
Array double arrow not aligned correctly; expected 1 space(s) between "'style'" and double arrow, but found 2.

'style' => [],


[phpcs] reported by reviewdog 🐢
WordPress.Arrays.MultipleStatementAlignment.DoubleArrowNotAligned
Array double arrow not aligned correctly; expected 3 space(s) between "'span'" and double arrow, but found 6.

'span' => [


[phpcs] reported by reviewdog 🐢
WordPress.Arrays.ArrayIndentation.CloseBraceNotAligned
Array closer not aligned correctly; expected 20 space(s) but found 38

'style' => [],],


[phpcs] reported by reviewdog 🐢
NormalizedArrays.Arrays.ArrayBraceSpacing.SpaceBeforeArrayCloserMultiLine
Expected a new line before the array closer in a multi line array. Found: no spaces

'style' => [],],


[phpcs] reported by reviewdog 🐢
Generic.Formatting.MultipleStatementAlignment.NotSameWarning
Equals sign not aligned with surrounding assignments; expected 2 spaces but found 6 spaces

$tags['svg'] = _wp_add_global_attributes(


[phpcs] reported by reviewdog 🐢
Universal.WhiteSpace.DisallowInlineTabs.NonIndentTabsUsed
Spaces must be used for mid-line alignment; tabs are not allowed

'g' => [],


[phpcs] reported by reviewdog 🐢
Universal.WhiteSpace.DisallowInlineTabs.NonIndentTabsUsed
Spaces must be used for mid-line alignment; tabs are not allowed

$tags['path'] = [


[phpcs] reported by reviewdog 🐢
Generic.Formatting.MultipleStatementAlignment.NotSameWarning
Equals sign not aligned with surrounding assignments; expected 1 space but found 5 spaces

$tags['path'] = [


[phpcs] reported by reviewdog 🐢
Squiz.Commenting.BlockComment.NoNewLine
Block comment text must start on a new line

/* translators: %1$s: Black Friday year */

@@ -0,0 +1,302 @@
<?php
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐢
Squiz.Commenting.FileComment.Missing
Missing file doc comment


/**
* @inheritdoc
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐢
Squiz.Commenting.VariableComment.MissingVar
Missing @var tag in member variable comment


/**
* @inheritdoc
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐢
Squiz.Commenting.VariableComment.MissingVar
Missing @var tag in member variable comment


/**
* @inheritdoc
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐢
Squiz.Commenting.VariableComment.MissingVar
Missing @var tag in member variable comment


$button_attr = new Attributes(
[
'style' => 'position: absolute; top: 0; right: 0; background: transparent; border: 0; color: #fff; padding: 0.5em; cursor: pointer;',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐢
WordPress.Arrays.MultipleStatementAlignment.DoubleArrowNotAligned
Array double arrow not aligned correctly; expected 1 space(s) between "'style'" and double arrow, but found 39.


return $date;
class Black_Friday {
public function __call( $name, $arguments ) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐢
Squiz.Commenting.FunctionComment.Missing
Missing doc comment for function __call()

'conditionals' => [ $this, 'should_display' ]
]
);
public static function __callStatic( $name, $arguments ) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐢
Squiz.Commenting.FunctionComment.Missing
Missing doc comment for function __callStatic()


return $content;
class End_Of_Year_Sale {
public function __call( $name, $arguments ) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐢
Squiz.Commenting.FunctionComment.Missing
Missing doc comment for function __call()

$date = $date->setTime( 23, 59 );

return $date;
public static function __callStatic( $name, $arguments ) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐢
Squiz.Commenting.FunctionComment.Missing
Missing doc comment for function __callStatic()

}
}
class Stellar_Sale {
public function __call( $name, $arguments ) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐢
Squiz.Commenting.FunctionComment.Missing
Missing doc comment for function __call()

@JPry JPry marked this pull request as ready for review October 31, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants