-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge master into bucket/order_modifiers_coupons_fees #2245
base: bucket/order_modifiers_coupon_fees
Are you sure you want to change the base?
Conversation
β¦be-common into feat/slr-support
This adds the stellarwp/uplink library and configures it.
β¦ibe-common into release/T24.ettin
This is an automated PR created by dpanta94. Generated by: https://github.com/the-events-calendar/tribe-common/actions/runs/11501275219
β¦elease/T24.fetch-a8ffa18 Version bump for release/T24.fetch
Feat/slr support
β¦logs added changelog for common
β¦emote 'templates/actions/process-changelog/action.yml'
β¦ 'templates/workflows/process-changelog.yml'
β¦aster π synced file(s) with the-events-calendar/actions
β¦mplates/workflows/release-branch.yml'
β¦aster π synced file(s) with the-events-calendar/actions
β¦orkflows/phpcs.yml'
β¦aster π synced file(s) with the-events-calendar/actions
β¦ate-for-fetch Amend Release date for fetch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
phpcs
[phpcs] reported by reviewdog πΆSquiz.Commenting.FunctionComment.Missing
Missing doc comment for function __callStatic()
public static function __callStatic( $name, $arguments ) { |
[phpcs] reported by reviewdog πΆGeneric.WhiteSpace.ScopeIndent.Incorrect
Line indented incorrectly; expected at least 1 tabs, found 0
/** |
[phpcs] reported by reviewdog πΆGeneric.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed
* @deprecated 6.3.0 |
[phpcs] reported by reviewdog πΆSquiz.Commenting.DocCommentAlignment.SpaceBeforeStar
Expected 1 space before asterisk; 5 found
* @deprecated 6.3.0 |
[phpcs] reported by reviewdog πΆWordPress.Arrays.MultipleStatementAlignment.DoubleArrowNotAligned
Array double arrow not aligned correctly; expected 2 space(s) between "'href'" and double arrow, but found 1.
tribe-common/src/Tribe/Field.php
Line 246 in cefbd1b
'href' => [], |
[phpcs] reported by reviewdog πΆWordPress.Arrays.MultipleStatementAlignment.DoubleArrowNotAligned
Array double arrow not aligned correctly; expected 1 space(s) between "'style'" and double arrow, but found 2.
tribe-common/src/Tribe/Field.php
Line 249 in cefbd1b
'style' => [], |
[phpcs] reported by reviewdog πΆWordPress.Arrays.MultipleStatementAlignment.DoubleArrowNotAligned
Array double arrow not aligned correctly; expected 3 space(s) between "'span'" and double arrow, but found 6.
tribe-common/src/Tribe/Field.php
Line 262 in cefbd1b
'span' => [ |
[phpcs] reported by reviewdog πΆWordPress.Arrays.ArrayIndentation.CloseBraceNotAligned
Array closer not aligned correctly; expected 20 space(s) but found 38
tribe-common/src/Tribe/Field.php
Line 294 in cefbd1b
'style' => [],], |
[phpcs] reported by reviewdog πΆNormalizedArrays.Arrays.ArrayBraceSpacing.SpaceBeforeArrayCloserMultiLine
Expected a new line before the array closer in a multi line array. Found: no spaces
tribe-common/src/Tribe/Field.php
Line 294 in cefbd1b
'style' => [],], |
[phpcs] reported by reviewdog πΆGeneric.Formatting.MultipleStatementAlignment.NotSameWarning
Equals sign not aligned with surrounding assignments; expected 2 spaces but found 6 spaces
tribe-common/src/Tribe/Field.php
Line 474 in cefbd1b
$tags['svg'] = _wp_add_global_attributes( |
[phpcs] reported by reviewdog πΆUniversal.WhiteSpace.DisallowInlineTabs.NonIndentTabsUsed
Spaces must be used for mid-line alignment; tabs are not allowed
tribe-common/src/Tribe/Field.php
Line 477 in cefbd1b
'g' => [], |
[phpcs] reported by reviewdog πΆUniversal.WhiteSpace.DisallowInlineTabs.NonIndentTabsUsed
Spaces must be used for mid-line alignment; tabs are not allowed
tribe-common/src/Tribe/Field.php
Line 484 in cefbd1b
$tags['path'] = [ |
[phpcs] reported by reviewdog πΆGeneric.Formatting.MultipleStatementAlignment.NotSameWarning
Equals sign not aligned with surrounding assignments; expected 1 space but found 5 spaces
tribe-common/src/Tribe/Field.php
Line 484 in cefbd1b
$tags['path'] = [ |
[phpcs] reported by reviewdog πΆSquiz.Commenting.BlockComment.NoNewLine
Block comment text must start on a new line
/* translators: %1$s: Black Friday year */ |
@@ -0,0 +1,302 @@ | |||
<?php |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[phpcs] reported by reviewdog πΆSquiz.Commenting.FileComment.Missing
Missing file doc comment
|
||
/** | ||
* @inheritdoc | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
/** | ||
* @inheritdoc | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
/** | ||
* @inheritdoc | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
$button_attr = new Attributes( | ||
[ | ||
'style' => 'position: absolute; top: 0; right: 0; background: transparent; border: 0; color: #fff; padding: 0.5em; cursor: pointer;', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[phpcs] reported by reviewdog πΆWordPress.Arrays.MultipleStatementAlignment.DoubleArrowNotAligned
Array double arrow not aligned correctly; expected 1 space(s) between "'style'" and double arrow, but found 39.
|
||
return $date; | ||
class Black_Friday { | ||
public function __call( $name, $arguments ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[phpcs] reported by reviewdog πΆSquiz.Commenting.FunctionComment.Missing
Missing doc comment for function __call()
'conditionals' => [ $this, 'should_display' ] | ||
] | ||
); | ||
public static function __callStatic( $name, $arguments ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[phpcs] reported by reviewdog πΆSquiz.Commenting.FunctionComment.Missing
Missing doc comment for function __callStatic()
|
||
return $content; | ||
class End_Of_Year_Sale { | ||
public function __call( $name, $arguments ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[phpcs] reported by reviewdog πΆSquiz.Commenting.FunctionComment.Missing
Missing doc comment for function __call()
$date = $date->setTime( 23, 59 ); | ||
|
||
return $date; | ||
public static function __callStatic( $name, $arguments ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[phpcs] reported by reviewdog πΆSquiz.Commenting.FunctionComment.Missing
Missing doc comment for function __callStatic()
} | ||
} | ||
class Stellar_Sale { | ||
public function __call( $name, $arguments ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[phpcs] reported by reviewdog πΆSquiz.Commenting.FunctionComment.Missing
Missing doc comment for function __call()
π« Ticket
[TICKET_ID]
ποΈ Description
π₯ Artifacts
βοΈ Checklist
npm run changelog
to add changelog file(s). More info herewpunit
orintegration
tests.wpunit
orintegration
tests.