Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blog: Accounts.js 1.0 Release Candidate #1478

Merged
merged 3 commits into from
Jan 8, 2024

Conversation

darkbasic
Copy link
Contributor

To be merged when MikroORM v6 stable and Accounts.js 1.0 Release Candidate get published.
Will be undrafted once that happens.

image: /blog-assets/accounts.js-1.0-rc/accounts-logo-wide.png
thumbnail: /blog-assets/accounts.js-1.0-rc/accounts-logo-squared.png
---

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great blog post!
Can you add a short intro about yourself at the beginning?
It could be written in a way where you write about yourself or in a way that I introduce you

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Urigo thanks! I've added an about me section but I ended up spoiling the content of the next article a bit :)
Currently the release is scheduled for tomorrow (January 8) but I wouldn't be surprised if Martin ends up postponing the MikroORM v6 release to Tuesday. I am partially to blame for the delay because I've uncovered some bugs while writing tests for the dataloader and I proposed a non trivial design change to fix one of them which couldn't have been implemented later in a point release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Urigo MikroORM v6 has just been released so this blog post is ready to release as well!

Copy link
Contributor

@beerose beerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments — mostly grammar-related.

website/pages/blog/accounts.js-1.0-rc.mdx Outdated Show resolved Hide resolved
website/pages/blog/accounts.js-1.0-rc.mdx Outdated Show resolved Hide resolved
website/pages/blog/accounts.js-1.0-rc.mdx Outdated Show resolved Hide resolved
website/pages/blog/accounts.js-1.0-rc.mdx Outdated Show resolved Hide resolved
website/pages/blog/accounts.js-1.0-rc.mdx Outdated Show resolved Hide resolved
website/pages/blog/accounts.js-1.0-rc.mdx Outdated Show resolved Hide resolved
website/pages/blog/accounts.js-1.0-rc.mdx Outdated Show resolved Hide resolved
website/pages/blog/accounts.js-1.0-rc.mdx Outdated Show resolved Hide resolved
website/pages/blog/accounts.js-1.0-rc.mdx Outdated Show resolved Hide resolved
website/pages/blog/accounts.js-1.0-rc.mdx Outdated Show resolved Hide resolved
@darkbasic
Copy link
Contributor Author

Thanks @beerose for your corrections, it's much appreciated!

@darkbasic darkbasic marked this pull request as ready for review January 8, 2024 08:39
@Urigo Urigo merged commit f85e6ee into the-guild-org:master Jan 8, 2024
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants