Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support multiple game modes #955

Merged
merged 5 commits into from
Jun 28, 2024
Merged

support multiple game modes #955

merged 5 commits into from
Jun 28, 2024

Conversation

Razzmatazzz
Copy link
Member

@Razzmatazzz Razzmatazzz commented Jun 23, 2024

Probably shouldn't deploy until we are scanning PVE prices. Otherwise, people will just be confused.

If we have other PRs we want to merge before we get PVE flea prices, we could hide the game mode toggle on the settings page and merge this PR, and then unhide it in a future PR.

Preview: https://preview.tarkov-dev.pages.dev/

@Razzmatazzz Razzmatazzz requested a review from a team as a code owner June 23, 2024 22:00
Copy link
Contributor

👋 Thanks for opening a pull request!

If you are new, please check out the trimmed down summary of our deployment process below:

  1. 👀 Observe the CI jobs and tests to ensure they are passing

  2. ✔️ Obtain an approval/review on this pull request

  3. 🚀 Deploy your pull request to the development environment with .deploy to development

  4. 🚀 Deploy your pull request to the production environment with .deploy

    If anything goes wrong, rollback with .deploy main

  5. 🎉 Merge!

Note: If you have a larger change and want to block deployments, you can run .lock --reason <reason> to lock all other deployments (remove with .unlock)

You can view the branch deploy usage guide for additional information

@Razzmatazzz
Copy link
Member Author

.deploy to development

Copy link
Contributor

Deployment Triggered 🚀

Razzmatazzz, started a branch deployment to development

You can watch the progress here 🔗

Branch: game-modes

Copy link
Contributor

Deployment Results ✅

Razzmatazzz successfully deployed branch game-modes to development

Show Results

https://fb10ce23.tarkov-dev.pages.dev

@Razzmatazzz
Copy link
Member Author

.deploy to development

Copy link
Contributor

Deployment Triggered 🚀

Razzmatazzz, started a branch deployment to development

You can watch the progress here 🔗

Branch: game-modes

Copy link
Contributor

Deployment Results ✅

Razzmatazzz successfully deployed branch game-modes to development

Show Results

https://146161b2.tarkov-dev.pages.dev

@Razzmatazzz
Copy link
Member Author

.deploy to development

Copy link
Contributor

Deployment Triggered 🚀

Razzmatazzz, started a branch deployment to development

You can watch the progress here 🔗

Branch: game-modes

Copy link
Contributor

Deployment Results ✅

Razzmatazzz successfully deployed branch game-modes to development

Show Results

https://a6aa694f.tarkov-dev.pages.dev

@Razzmatazzz
Copy link
Member Author

.deploy

Copy link
Contributor

Deployment Triggered 🚀

Razzmatazzz, started a branch deployment to production

You can watch the progress here 🔗

Branch: game-modes

Copy link
Contributor

Deployment Results ✅

Razzmatazzz successfully deployed branch game-modes to production

Environment URL: tarkov.dev

@Razzmatazzz Razzmatazzz merged commit ea4aee1 into main Jun 28, 2024
2 checks passed
@Razzmatazzz Razzmatazzz deleted the game-modes branch June 28, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants