First run at 500 error handling in fetch_resource #47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't intended as a proper solution for #46 but it's an example of what I'm suggesting initially as a better way to handle 500s (and I added 405s as they were easier for me to test)
Since the higher level "get this, search that" client methods don't put
fetch_resource
in a try block (typically that is done when trying to parse the actual JSON response), the new exception should be thrown all the way back to the calling script so it can be handled appropriately by end developers.e.g.