-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP2 bug fix #100
HTTP2 bug fix #100
Conversation
.map((link:LinkObject) => link.href) | ||
.map(href => { | ||
return links_with_duplicates.find(link => link.href === href); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is much more readable, thank you. My first impression of this is the same: links
gets set to dedupedLinkArray
filtered for links that also exist in the original input array. Seems like an unnecessary check since dedupedLinkArray
is already derived from links_with_duplicates
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, I'm so glad that you discovered the (cookie) cache clearing trick!
What does this PR do?
hasOwnProperty
helper functionWhy are we doing this? How does it help us?
Crashes are bad
How/where should this be tested?
On it's own and in conjunction with the lambda
What are potential areas for future improvement? Are there any dependencies (especially on 3rd party code)?
There's plenty more refactoring to do, but I figured this PR was getting large enough
What are the relevant tickets, tasks, or documents?
https://calmatters.atlassian.net/jira/software/projects/PRD/boards/15?assignee=712020%3A97109b4a-04d7-464a-b1ce-adb6439221fb&selectedIssue=PRD-7402
Have you done the following, if applicable:
(optional: add explanation between parentheses)