Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output args, refactoring #102

Merged
merged 4 commits into from
Sep 12, 2024
Merged

Output args, refactoring #102

merged 4 commits into from
Sep 12, 2024

Conversation

BatMiles
Copy link
Member

@BatMiles BatMiles commented Sep 5, 2024

What does this PR do?

  • Changes the title output key from args to title
  • Returns more of the config options
  • Fixes an issue with dedupLinks
  • Adds tests for dedupLinks and getSocialLinks
  • Adds some urls to the SOCIAL_URLS array, and moves it to a new file

Why are we doing this? How does it help us?

Outputting the args will help the Blacklight Archiver keep track of which scans were run with which args. Refactoring is just nice.

How/where should this be tested?

Alone as the collector, and in conjunction with the lambda

Have you done the following, if applicable:

(optional: add explanation between parentheses)

  • Tested manually
  • Checked for performance implications? ( )
  • Checked for security vulnerabilities? ( )
  • Added/updated documentation? ( )
  • Added/updated tests

@BatMiles BatMiles merged commit 4d30631 into main Sep 12, 2024
1 check passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants