Package updates #96
Merged
Package updates #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dphiffer
reviewed
Aug 1, 2024
src/collector.ts
Outdated
| @@ -128,7 +128,7 @@ export const collect = async (inUrl: string, args: CollectorOptions) => { | |||
| }; | |||
| } | |||
| logger.info(`Started Puppeteer with pid ${browser.process().pid}`); | |||
| page = (await browser.pages())[0]; | |||
| page = await browser.newPage(); | |||
There was a problem hiding this comment.
I think the reason we did it this way is to avoid having a useless about:blank. It's purely aesthetic I realize, but this does feel slightly worse...
There was a problem hiding this comment.
ahhhh interesting. I'll revert it then. I thought for a minute that the syntax change was fixing the sacbee issue, but it didn't.
There was a problem hiding this comment.
yeah, you never know, if it did fix sacbee I would be all in!
dphiffer
approved these changes
Aug 1, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
package updates, and a change to how we get the
page