Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing overlays, outdated inputs in java/kotlin #54

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

nartsisss
Copy link
Contributor

@nartsisss nartsisss commented Jul 24, 2024

Depends on #53
Fixes #55

@nartsisss nartsisss changed the title fix: add missing overlays in java and kotlin flakes fix: add missing overlays to java and kotlin flakes Jul 24, 2024
@nartsisss nartsisss marked this pull request as draft July 24, 2024 23:22
@nartsisss nartsisss marked this pull request as ready for review July 24, 2024 23:22
@vbrandl vbrandl mentioned this pull request Aug 13, 2024
@vbrandl
Copy link

vbrandl commented Aug 13, 2024

I think since NixOS/nixpkgs@ea0bc32 overriding jre for the maven package is not possible and causes the evaluation to fail with

error: function 'anonymous lambda' called with unexpected argument 'jre'

So the line maven = prev.maven.override { jre = jdk; }; has to be replaced with maven = prev.maven.override { jdk_headless = jdk; };

@nartsisss nartsisss changed the title fix: add missing overlays to java and kotlin flakes fix: missing overlays, outdated inputs in java/kotlin Aug 14, 2024
Copy link

@hatch01 hatch01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. And important, to have the right jdk

@lucperkins
Copy link
Contributor

Sorry for the delay. Somehow I didn't get the notification for this. LGTM!

@lucperkins lucperkins merged commit 16140e8 into the-nix-way:main Sep 12, 2024
1 check failed
@nartsisss nartsisss deleted the fix/overlays branch September 13, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Java Template installs wrong JDK
4 participants