-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ALDL link-layer type #32
base: master
Are you sure you want to change the base?
Conversation
You should probably link to https://holden.asger.xyz/wiki/Holden:ALDL_(8192_Baud) in the page for LINKTYPE_ALDL, to describe at least some of the ALDL payload. |
And if it's different in the 160 baud link and the 8192 baud link, should this be LINKTYPE_ALDL_8192_BAUD? |
And, as the Wikipedia page for ALDL indicates, how model-dependent is the format? |
Documentation is scarce, but the majority of ALDL devices that operate at 8192 baud has a consistent frame format of I considered creating |
I can change the definition to As for the site link, the site itself is a WIP, and the domain isn't finalized. Hence why I was hesitant to include it in long-term documentation at this stage. |
...but is |
It is, but I'd argue that transcends the link layer. Detecting the vehicle model can be done with relatively straightforward heuristics. The purpose of my pull request, is to allow captured ALDL frames to be passed between programs. Anything outside of the message ID, length and checksum are beyond the link-layer, and is the responsibility of a program/user to interpret the meaning of the data section. |
This needs to be updated, as 297, 298, and 299 have been assigned to other link-layer types. |
PR to match #1143.
Added link-layer type 297 for GM ALDL as described here: Holden - ALDL (8192 Baud)