fix for MEG monitor - corrected projection shape

[JanStasin]

The bug:

in monitors.py file in line 559 when the gain matrix for the MEG monitor is specified (when running region-wise simulation)

the code was:

gain = numpy.zeros((self.gain.shape[0], conn.number_of_regions))

this causes the gain matrix shape to have shape[1] equal to the number of regions regardless of whether they are cortical or subcortical. The resulting gain matrix has shape:
[number of sources, number of regions]

A few lines later in line 569, when considering subcortical regions (if they are specified in the connectome), they are stacked onto the gain matrix again, causing the matrix to have the shape of:
[number of sources, number of regions + number of subcortical regions]

When running the simulation this causes an error related to the mismatch in the shape of the specified and resulting outputs of the monitor.

I have changed the line 559 to adjust the shape[1] of the gain matrix:

gain = numpy.zeros((self.gain.shape[0], conn.number_of_regions -len(numpy.where(~conn.cortical)[0])))

and this created correct outputs.

[maedoc]

Thanks for your effort on this one. Please ensure tests are passing and that you considered other cases handled by this method as well.

[JanStasin]

Hi Marmaduke, Apologies for that. I have limited experience in that regard. I just noticed jupyter notebooks not working for me and spend quite some time looking for a solution and when I found it I decided to share. This or next week I shall sit down with Dionysios and try to see what we can do about the solution not passing some tests. best wishes Jan wt., 26 kwi 2022 o 22:53 marmaduke woodman ***@***.***> napisał(a):

…

Thanks for your effort on this one. Please ensure tests are passing and that you considered other cases handled by this method as well. — Reply to this email directly, view it on GitHub <#553 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AE6ZO5XIB6QNFWNLEDHHW3LVHBJUZANCNFSM5ULXLUKA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[maedoc]

I get that, no problem, but the fix cannot be merged like this. Please re-open when ready. In the meantime, I'll note this as a bug #556