Remove explicit status from return code, instead relying on TypedError's status() method.
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Catchers now carry `TypeId` and type name for collision detection - Transient updated to 0.3, with new derive macro - Added `Transient` or `Static` implementations for error types - CI should now pass
See catch attribute docs for the new syntax.
- Add Error trait - Use Option<Box<dyn Error>> - Update Responder to return a result - Update all core implementations
- Update Responder derive to match new trait - Update lifecycle to deal with error types correctly - Update catcher rank to ignore type - now handled by lifecycle
Still has several major missing features, but is back to passing CI.
- The previous `on_request` was unsafe, now uses a separate `filter_request` method to ensure `error` only contains immutable borrows of `Request`. - Added full safety comments and arguements to `erased`. - Added extra logic to upgrade, to prevent upgrading if an error has been thrown.
- Also makes some changes to the catch attribute to fix issues identified during testing
- Add `FromParamError` and `FromSegementsError` - Updated codegen to generate these types. - Fixed some codegen issues along the way.
- Updates tests to use new `#[catch]` syntax - Updates error-handling to take full advantage of new features - Fixes priority issue with catchers
- Avoid allocating in a bunch of cases - Fix responder to work in as many cases as possible - Fix a couple minor warnings
the10thWiz
force-pushed
the
typed-catchers
branch
from
c263a6c to
0b72867
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is the direction I want to go. It simplifies the API a bit, going from
(Status, Option<dyn TypedError>)toBox<dyn TypedError>. This also eases the transition for existing code, since this is going fromStatusin 0.5 toBox<dyn TypedError>with this PR.StatusimplementsTypedError, so a basic upgrade, with no additional work, is to simply wrap theStatusin a Box.The major reason I want to move this route, is that in most cases, the appropriate status code can be derived from the error itself. There may be a few cases where it can't, such as
std::io::Error, which may have different meanings depending on the operation that was attempted. (E.g., normally aNotFounderror would map to a 404 status, but if the server always expects the file to exist, it might actually map to a 500 error). These cases can pretty trivially be handled by defining useful wrappers, in much the same way asResponders - and thesource()mechanism provides a convenient way to support catching the inner type.