Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple task with same name bug #35

Closed
wants to merge 2 commits into from

Conversation

mamidinilesh
Copy link
Contributor

Having multiple task with same name, created at different time, produces a bug.
It creates multiple entries of version in task_recorder. they above code will check, whether similar file exists or not

@mamidinilesh mamidinilesh deleted the patch-1 branch May 2, 2018 10:37
@mamidinilesh mamidinilesh restored the patch-1 branch May 2, 2018 10:37
@mamidinilesh mamidinilesh reopened this May 2, 2018
@theSteveMitchell
Copy link
Owner

@mamidinilesh would you mind elaborating a little more on the bug you're seeing? Do you mean to say that rake after_party:status lists the same job twice?

@manuca
Copy link

manuca commented Feb 4, 2022

Hey @theSteveMitchell I've just seen this happen to me version (1.11.2)

To reproduce you need to generate 2 tasks with the same name. I did the first one months ago, ran it and all went well back then. Months later I needed a similar task, and gave it the same name (accidentally). When I rake after_part:run the last task it re-ran the previous version although there was an entry in the task_records table (from months ago).

Final outcome in the task_records table is the inclusion of 3 timestamps: the first one, a duplicate of the first one, and the new one.

Having multiple task with same name, created at different time, produces a bug.
It creates multiple entries of version in task_recorder. they above code will check, whether similar file exists or not
@theSteveMitchell
Copy link
Owner

theSteveMitchell commented Apr 7, 2022

@manuca Thanks for the details. I'll rebase and merge once we can get a passing CI

@theSteveMitchell
Copy link
Owner

merged to #71 and fixed lint errors there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants