Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sorted-by-name): apps and libraries are sorted by name #86

Closed
wants to merge 2 commits into from
Closed

feat(sorted-by-name): apps and libraries are sorted by name #86

wants to merge 2 commits into from

Conversation

carotkut94
Copy link

@carotkut94 carotkut94 commented Jan 11, 2022 •
edited
Loading

we all find it very easy to lookup apps or libraries by name, thus sorting the list of apps and libraries makes sense, a lot to me.
thus the PR.

@carotkut94
Copy link
Author

carotkut94 commented Jan 13, 2022 •
edited
Loading

@theapache64 is it good to merge?

@theapache64
Copy link
Owner

theapache64 commented Jan 13, 2022 •
edited
Loading

Hi @carotkut94, Thanks for this PR, but this is already planned for 1.2.0. The ideal solution would be to ask the server to sort it. Will implement this as part of #87. Next time please discuss before raising a PR.

@carotkut94 carotkut94 deleted the sorted-by-name branch January 13, 2022 16:22
@theapache64
Copy link
Owner

theapache64 commented Jan 16, 2022 •
edited
Loading

@carotkut94 Just FYI : f5e0a45
Thanks for the feedback :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carotkut94 @theapache64