Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server improvements #39

Merged
merged 20 commits into from
Oct 18, 2023
Merged

Server improvements #39

merged 20 commits into from
Oct 18, 2023

Conversation

thearyadev
Copy link
Owner

This PR is a re-write of the server script.

primary changes:

  • Add abstractions
  • Use explicit cache on data sources to ensure all database access is cached correctly.
  • Add explicit global dependency use using FastAPI Depends()

@thearyadev thearyadev merged commit 0be422a into main Oct 18, 2023
5 checks passed
@thearyadev thearyadev deleted the server-improvements branch December 15, 2023 02:05
thearyadev added a commit that referenced this pull request Jan 19, 2024
* fix some tests

* add testing workflow

* rename archive file

* add database test steps

* Add mysql port num

* add sleep step to allow mysql to start

* use docker instead of gh action for db server

* attempt to fix connection

* attempt to fix connection

* modify second connection string

* update archive with season 6 data

* run pytest on pr

* combine workflows to allow for conditional exec

* adjust on param

* adjust on param

* fix names

* Rebuild server logic

* deprecate old server script

* Add docs & remove unused dependencies

* remove old server script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant