feat: add clearUserID to AppEventsLogger (setUserId(null) throws ex…

…ception from SDK) (#185)
thebergamo · Jan 17, 2022 · b3cd260 · b3cd260
1 parent dd6aaf8
commit b3cd260
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 2 deletions.
diff --git a/android/src/main/java/com/facebook/reactnative/androidsdk/FBAppEventsLoggerModule.java b/android/src/main/java/com/facebook/reactnative/androidsdk/FBAppEventsLoggerModule.java
@@ -260,6 +260,14 @@ public void setUserID(final String userID) {
          mAppEventLogger.setUserID(userID);
      }
 
+    /**
+     * Clears the currently set user id.
+     */
+     @ReactMethod
+     public void clearUserID() {
+         mAppEventLogger.clearUserID();
+     }
+
      /**
       * Returns the set user id or null if not set
       *

diff --git a/ios/RCTFBSDK/core/RCTFBSDKAppEvents.m b/ios/RCTFBSDK/core/RCTFBSDKAppEvents.m
@@ -119,6 +119,11 @@ - (dispatch_queue_t)methodQueue
   [FBSDKAppEvents.shared setUserID:userID];
 }
 
+RCT_EXPORT_METHOD(clearUserID)
+{
+  [FBSDKAppEvents clearUserID];
+}
+
 RCT_EXPORT_BLOCKING_SYNCHRONOUS_METHOD(getUserID)
 {
   return [FBSDKAppEvents.shared userID];

diff --git a/jest/mocks/index.js b/jest/mocks/index.js
@@ -52,6 +52,7 @@ export default {
     logEvent: jest.fn(),
     logPurchase: jest.fn(),
     setUserID: jest.fn(),
+    clearUserID: jest.fn(),
     AppEventParams: mockAppEventParams,
     AppEvents: mockAppEvents,
   },

diff --git a/src/FBAppEventsLogger.ts b/src/FBAppEventsLogger.ts
@@ -296,12 +296,19 @@ export default {
 
   /**
    * Sets a custom user ID to associate with all app events.
-   * The userID is persisted until it is cleared by passing nil.
+   * The userID is persisted until it is cleared by clearUserID method.
    */
-  setUserID(userID: string | null) {
+  setUserID(userID: string) {
     AppEventsLogger.setUserID(userID);
   },
 
+  /**
+   * Clears the currently set user id.
+   */
+  clearUserID() {
+    AppEventsLogger.clearUserID();
+  },
+
   /**
    * Returns user id or null if not set
    */