Skip to content

Commit

Permalink
Merge pull request #658 from thebuilder/feat/upgrade
Browse files Browse the repository at this point in the history
Switch to Biome.js
  • Loading branch information
thebuilder authored Feb 5, 2024
2 parents db19517 + 655631e commit c72a939
Show file tree
Hide file tree
Showing 34 changed files with 3,955 additions and 4,685 deletions.
7 changes: 0 additions & 7 deletions .eslintignore

This file was deleted.

224 changes: 0 additions & 224 deletions .eslintrc.js

This file was deleted.

9 changes: 3 additions & 6 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,10 @@ jobs:
name: Release
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Install PNPM
uses: pnpm/action-setup@v2
with:
version: 8
- run: corepack enable
- uses: actions/checkout@v4
- name: Setup Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: 20
cache: 'pnpm'
Expand Down
22 changes: 8 additions & 14 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
@@ -1,32 +1,26 @@
name: Test

on: [push, pull_request]
on: [ push, pull_request ]

jobs:
build:
runs-on: ubuntu-latest

strategy:
matrix:
node-version: [16.x, 18.x]

steps:
- uses: actions/checkout@v3
- uses: pnpm/action-setup@v2
with:
version: 8
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
- run: corepack enable
- uses: actions/checkout@v4
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
node-version: 20
cache: 'pnpm'
- name: Install dependencies
run: pnpm install
- name: Lint
run: pnpm lint
run: pnpm biome ci .
- name: Test
run: pnpm test
env:
CI: true
- name: Build
run: yarn build
run: pnpm build
1 change: 1 addition & 0 deletions .npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ npm-debug.log
.project
.tmp
.eslintignore
biome.json
.flowconfig
.editorconfig
storybook/.storybook
Expand Down
5 changes: 0 additions & 5 deletions .prettierignore

This file was deleted.

6 changes: 3 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,10 @@ Here's what each part of the commit message means:
updating dependencies).
- `<subject>`: A short description of the change.

### Code Style
### Code Style and Linting

`react-intersection-observer` uses [Prettier](https://prettier.io/) for code
formatting. Please ensure that your changes are formatted with Prettier before
`react-intersection-observer` uses [Biome](https://biomejs.dev/) for code
formatting and linting. Please ensure that your changes are formatted with Biome before
submitting your pull request.

### Testing
Expand Down
Loading

0 comments on commit c72a939

Please sign in to comment.