Update to rails 7 #828
Annotations
10 errors and 12 warnings
Tests:
spec/features/responses/location_picker_spec.rb#L25
response form location picker picking a location
|
Tests:
spec/jobs/tabular_import_operation_job_spec.rb#L25
TabularImportOperationJob with simple validation error handles errors gracefully
Failure/Error:
errors.keys.each do |attribute|
errors.full_messages_for(attribute).each do |error|
add_run_error(I18n.t("operation.row_error", row: row_number, error: error))
end
end
NoMethodError:
undefined method `keys' for #<ActiveModel::Errors [#<ActiveModel::Error attribute=phone, type=at_least_digits, options={:num=>9}>]>
errors.keys.each do |attribute|
^^^^^
Did you mean? key?
|
Tests:
spec/models/user_import_spec.rb#L217
UserImport with duplicate usernames and too many errors returns appropriate errors and ignores deleted data
Failure/Error:
errors.keys.each do |attribute|
errors.full_messages_for(attribute).each do |error|
add_run_error(I18n.t("operation.row_error", row: row_number, error: error))
end
end
NoMethodError:
undefined method `keys' for #<ActiveModel::Errors [#<ActiveModel::Error attribute=login, type=taken, options={:value=>"a.bob"}>]>
errors.keys.each do |attribute|
^^^^^
Did you mean? key?
|
Tests:
spec/models/user_import_spec.rb#L188
UserImport with simple validation error handles errors
Failure/Error:
errors.keys.each do |attribute|
errors.full_messages_for(attribute).each do |error|
add_run_error(I18n.t("operation.row_error", row: row_number, error: error))
end
end
NoMethodError:
undefined method `keys' for #<ActiveModel::Errors [#<ActiveModel::Error attribute=phone, type=at_least_digits, options={:num=>9}>]>
errors.keys.each do |attribute|
^^^^^
Did you mean? key?
|
Tests:
spec/models/option_set_import_spec.rb#L115
OptionSets::Import with invalid coordinates should correctly report errors
Failure/Error:
errors.keys.each do |attribute|
errors.full_messages_for(attribute).each do |error|
add_run_error(I18n.t("operation.row_error", row: row_number, error: error))
end
end
NoMethodError:
undefined method `keys' for #<ActiveModel::Errors [#<ActiveModel::Error attribute=latitude, type=less_than_or_equal_to, options={:if=>:coordinates?, :value=>0.22448416e3, :count=>90}>]>
errors.keys.each do |attribute|
^^^^^
Did you mean? key?
|
Tests:
spec/models/question_import_spec.rb#L87
Questions::Import with missing titles should not be able to import
Failure/Error:
errors.keys.each do |attribute|
errors.full_messages_for(attribute).each do |error|
add_run_error(I18n.t("operation.row_error", row: row_number, error: error))
end
end
NoMethodError:
undefined method `keys' for #<ActiveModel::Errors [#<ActiveModel::Error attribute=base, type=at_least_one_name, options={}>]>
errors.keys.each do |attribute|
^^^^^
Did you mean? key?
|
Tests:
spec/models/question_import_spec.rb#L52
Questions::Import with non existent option set should not be able to import
Failure/Error:
errors.keys.each do |attribute|
errors.full_messages_for(attribute).each do |error|
add_run_error(I18n.t("operation.row_error", row: row_number, error: error))
end
end
NoMethodError:
undefined method `keys' for #<ActiveModel::Errors [#<ActiveModel::Error attribute=option_set, type=blank, options={:if=>#<Proc:0x00007fbc92cc4970 /home/runner/work/nemo/nemo/app/models/question.rb:89 (lambda)>}>]>
errors.keys.each do |attribute|
^^^^^
Did you mean? key?
|
Tests:
spec/models/question_import_spec.rb#L65
Questions::Import with incorrect formats should not be able to import
Failure/Error:
errors.keys.each do |attribute|
errors.full_messages_for(attribute).each do |error|
add_run_error(I18n.t("operation.row_error", row: row_number, error: error))
end
end
NoMethodError:
undefined method `keys' for #<ActiveModel::Errors [#<ActiveModel::Error attribute=code, type=invalid, options={:unless=>#<Proc:0x00007fbc92cc6108 /home/runner/work/nemo/nemo/app/models/question.rb:87 (lambda)>, :value=>"localite 2"}>]>
errors.keys.each do |attribute|
^^^^^
Did you mean? key?
|
Tests:
spec/models/question_import_spec.rb#L78
Questions::Import with missing required fields - code and option set should not be able to import
Failure/Error:
errors.keys.each do |attribute|
errors.full_messages_for(attribute).each do |error|
add_run_error(I18n.t("operation.row_error", row: row_number, error: error))
end
end
NoMethodError:
undefined method `keys' for #<ActiveModel::Errors [#<ActiveModel::Error attribute=qtype_name, type=blank, options={}>]>
errors.keys.each do |attribute|
^^^^^
Did you mean? key?
|
Tests
Process completed with exit code 1.
|
Tests
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/cache@v2, actions/setup-node@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Tests:
app/javascript/components/Filters/model.js#L133
Unexpected console statement
|
Tests:
app/javascript/components/conditions/ConditionSetFormField/ConditionFormField/component.js#L69
Unexpected console statement
|
Tests:
app/javascript/components/conditions/ConditionSetFormField/ConditionFormField/component.js#L112
Unexpected console statement
|
Tests:
app/javascript/components/conditions/ConditionSetFormField/ConditionFormField/model.js#L148
Unexpected console statement
|
Tests:
app/javascript/packs/enketo.js#L43
Unexpected console statement
|
Tests:
app/javascript/packs/enketo.js#L57
Unexpected alert
|
Tests:
app/javascript/packs/enketo.js#L80
Unexpected console statement
|
Tests:
app/javascript/packs/enketo.js#L91
Unexpected alert
|
Tests:
app/javascript/packs/enketo.js#L94
Unexpected console statement
|
Tests:
spec/models/broadcaster_spec.rb#L16
Sms::Broadcaster with adapter set in mission settings builds appropriate adapter and Sms::Broadcast instance
Skipped: Temporarily skipped with xit
|
Tests
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|