Upgrade to latest ruby to resolve conflict #872
Annotations
10 errors and 13 warnings
Tests:
spec/features/users/user_form_spec.rb#L51
user form admin user in admin mode create and edit user should work
Failure/Error:
def password_reset_instructions(user, mission: nil)
@mission = mission
@reset_url = reset_url(user)
@site_name = site_name
mail(to: user.email, reply_to: coordinator_emails(mission),
subject: t("notifier.password_reset_instructions"))
end
ArgumentError:
wrong number of arguments (given 2, expected 1)
|
Tests:
spec/features/users/user_form_spec.rb#L14
user form admin user in mission mode create and edit user should work
Failure/Error:
def password_reset_instructions(user, mission: nil)
@mission = mission
@reset_url = reset_url(user)
@site_name = site_name
mail(to: user.email, reply_to: coordinator_emails(mission),
subject: t("notifier.password_reset_instructions"))
end
ArgumentError:
wrong number of arguments (given 2, expected 1)
|
Tests:
spec/features/responses/location_picker_spec.rb#L25
response form location picker picking a location
Failure/Error: click_link("Joe Batt's Arm", match: :first)
Selenium::WebDriver::Error::UnexpectedAlertOpenError:
unexpected alert open: {Alert text : Search Error}
(Session info: chrome-headless-shell=121.0.6167.139)
|
Tests:
spec/models/mission_destroy_spec.rb#L66
mission destroy should delete all objects in mission
Failure/Error:
def broadcast(to:, subject:, body:, mission:)
@Body = body
@mission = mission
@site_name = site_name
# TODO: We should send a separate email to each recipient
# like we do with an SMS broadcast
mail(to: to, subject: "[#{site_name}] #{subject}")
end
ArgumentError:
wrong number of arguments (given 1, expected 0; required keywords: to, subject, body, mission)
|
Tests:
spec/features/option_sets/option_set_import_spec.rb#L24
option set import happy path
|
Tests:
spec/features/users/password_reset_spec.rb#L84
password reset if not logged in password update with invalid password should show validation message
Failure/Error: Time.zone = current_mission_config.timezone.to_s
NoMethodError:
undefined method `timezone' for nil
|
Tests:
spec/features/users/password_reset_spec.rb#L25
password reset if not logged in reset request with user with email address should not automatically reset password
Failure/Error:
def password_reset_instructions(user, mission: nil)
@mission = mission
@reset_url = reset_url(user)
@site_name = site_name
mail(to: user.email, reply_to: coordinator_emails(mission),
subject: t("notifier.password_reset_instructions"))
end
ArgumentError:
wrong number of arguments (given 2, expected 1)
|
Tests:
spec/features/users/password_reset_spec.rb#L31
password reset if not logged in reset request with user with email address should work when using login instead of email
Failure/Error:
def password_reset_instructions(user, mission: nil)
@mission = mission
@reset_url = reset_url(user)
@site_name = site_name
mail(to: user.email, reply_to: coordinator_emails(mission),
subject: t("notifier.password_reset_instructions"))
end
ArgumentError:
wrong number of arguments (given 2, expected 1)
|
Tests:
spec/features/users/password_reset_spec.rb#L16
password reset if not logged in reset request with user with email address submitting password reset form should reset perishable token and send email
Failure/Error:
def password_reset_instructions(user, mission: nil)
@mission = mission
@reset_url = reset_url(user)
@site_name = site_name
mail(to: user.email, reply_to: coordinator_emails(mission),
subject: t("notifier.password_reset_instructions"))
end
ArgumentError:
wrong number of arguments (given 2, expected 1)
|
Tests:
spec/jobs/broadcast_operation_job_spec.rb#L17
BroadcastOperationJob#perform saves sent_at time
Failure/Error:
def broadcast(to:, subject:, body:, mission:)
@Body = body
@mission = mission
@site_name = site_name
# TODO: We should send a separate email to each recipient
# like we do with an SMS broadcast
mail(to: to, subject: "[#{site_name}] #{subject}")
end
ArgumentError:
wrong number of arguments (given 1, expected 0; required keywords: to, subject, body, mission)
|
Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/cache@v2, actions/setup-node@v1, nanasess/setup-chromedriver@master. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Tests
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/cache@v2, actions/setup-node@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Tests:
app/javascript/components/Filters/model.js#L133
Unexpected console statement
|
Tests:
app/javascript/components/conditions/ConditionSetFormField/ConditionFormField/component.js#L69
Unexpected console statement
|
Tests:
app/javascript/components/conditions/ConditionSetFormField/ConditionFormField/component.js#L112
Unexpected console statement
|
Tests:
app/javascript/components/conditions/ConditionSetFormField/ConditionFormField/model.js#L148
Unexpected console statement
|
Tests:
app/javascript/packs/enketo.js#L43
Unexpected console statement
|
Tests:
app/javascript/packs/enketo.js#L57
Unexpected alert
|
Tests:
app/javascript/packs/enketo.js#L80
Unexpected console statement
|
Tests:
app/javascript/packs/enketo.js#L91
Unexpected alert
|
Tests:
app/javascript/packs/enketo.js#L94
Unexpected console statement
|
Tests:
spec/models/broadcaster_spec.rb#L16
Sms::Broadcaster with adapter set in mission settings builds appropriate adapter and Sms::Broadcast instance
Skipped: Temporarily skipped with xit
|
Tests
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|