Skip to content

Commit

Permalink
partially revert upgrade to selenium-webdriver to avoid prod crash
Browse files Browse the repository at this point in the history
  • Loading branch information
cooperka committed Feb 1, 2024
1 parent ac3dd2a commit aa9c767
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
4 changes: 3 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,9 @@ group :development, :test do
gem "capybara-screenshot", "~> 1.0"
gem "launchy", "~> 2.5" # For auto-opening capybara html file
gem "puma", "~> 5.6"
gem "selenium-webdriver", "~> 4.11"
# TODO: v4.17.0 requires base64 (~> 0.2) which conflicts with something in production.
# Try again on Rails 7?
gem "selenium-webdriver", "~> 4.16.0"

# Debugging
gem "pry", "~> 0.13"
Expand Down
5 changes: 2 additions & 3 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -542,8 +542,7 @@ GEM
scrypt (3.0.7)
ffi-compiler (>= 1.0, < 2.0)
select2-rails (4.0.13)
selenium-webdriver (4.17.0)
base64 (~> 0.2)
selenium-webdriver (4.16.0)
rexml (~> 3.2, >= 3.2.5)
rubyzip (>= 1.2.2, < 3.0)
websocket (~> 1.0)
Expand Down Expand Up @@ -720,7 +719,7 @@ DEPENDENCIES
scout_apm (~> 5.0)
scrypt (~> 3.0)
select2-rails (~> 4.0)
selenium-webdriver (~> 4.11)
selenium-webdriver (~> 4.16.0)
sentry-rails (~> 5.0)
sentry-ruby (~> 5.0)
spinjs-rails (~> 1.3.0)
Expand Down

0 comments on commit aa9c767

Please sign in to comment.