Upgrade to Elixir 1.18.1, Erlang 27.2

thechangelog · Jan 7, 2025 · 7915ef2 · 7915ef2
1 parent 4a30b61
commit 7915ef2
Show file tree

Hide file tree

Showing 21 changed files with 42 additions and 42 deletions.
diff --git a/.tool-versions b/.tool-versions
@@ -1,8 +1,8 @@
 1password-cli 2.29.0
 dagger 0.6.4
 direnv 2.34.0
-elixir 1.16.3
-erlang 26.2.5
+elixir 1.18.1-otp-27
+erlang 27.2
 flyctl 0.2.65
 golang 1.22.4
 nodejs 20.14.0

diff --git a/lib/changelog/stats/parser.ex b/lib/changelog/stats/parser.ex
@@ -43,7 +43,7 @@ defmodule Changelog.Stats.Parser do
       }
     rescue
       exception ->
-        Logger.info("Stats: Parse Error '#{exception.message}'\n#{line}")
+        Logger.info("Stats: Parse Error '#{Exception.message(exception)}'\n#{line}")
         Sentry.capture_exception(exception)
         %Entry{bytes: 0}
     end

diff --git a/lib/changelog_web/templates/admin/episode/_table.html.heex b/lib/changelog_web/templates/admin/episode/_table.html.heex
@@ -1,4 +1,4 @@
-<%# sometimes this table is rendered within a specific podcast context, sometimes not %>
+<% # sometimes this table is rendered within a specific podcast context, sometimes not %>
 <table class="ui celled striped unstackable table">
   <thead>
     <tr>

diff --git a/lib/changelog_web/templates/admin/episode_request/_table.html.heex b/lib/changelog_web/templates/admin/episode_request/_table.html.heex
@@ -1,4 +1,4 @@
-<%# sometimes this table is rendered within a specific podcast or person context, sometimes not %>
+<% # sometimes this table is rendered within a specific podcast or person context, sometimes not %>
 <table class="ui celled striped unstackable table">
   <thead>
     <tr>

diff --git a/lib/changelog_web/templates/news_item/fresh.html.eex b/lib/changelog_web/templates/news_item/fresh.html.eex
@@ -1,6 +1,6 @@
 <a id="feed" class="anchor"></a>
 <div class="feed">
-  <%#= render("_subnav.html", assigns) %>
+  <% #= render("_subnav.html", assigns) %>
 
   <%= for item_or_ad <- items_with_ads(@items, @ads), do: render_item_summary_or_ad(item_or_ad, assigns) %>
   <%= render(SharedView, "_more_button.html", assigns) %>

diff --git a/lib/changelog_web/templates/news_item/index.html.eex b/lib/changelog_web/templates/news_item/index.html.eex
@@ -4,7 +4,7 @@
 
 <a id="feed" class="anchor"></a>
 <div class="feed">
-  <%#= render("_subnav.html", assigns) %>
+  <% #= render("_subnav.html", assigns) %>
 
   <%= if @page.page_number == 1 do %>
     <%= for item <- @pinned, do: render_item_summary_or_ad(item, assigns) %>

diff --git a/lib/changelog_web/templates/news_item/top.html.eex b/lib/changelog_web/templates/news_item/top.html.eex
@@ -3,7 +3,7 @@
   <nav class="subnav">
     <ul class="subnav-list">
       <!-- <li class="subnav-list-item">
-        <%#= link("New", to: "/", title: "Recent News") %>
+        <% #= link("New", to: "/", title: "Recent News") %>
       </li> -->
       <li class="subnav-list-item <%= SharedHelpers.active_class(@conn, [~r/\Anews_item-top\z/, "news_item-top_week"]) %>">
         <%= link("This Week", to: Routes.news_item_path(@conn, :top_week), title: "Top developer news this week") %>

diff --git a/lib/changelog_web/templates/news_item_comment/_form.html.eex b/lib/changelog_web/templates/news_item_comment/_form.html.eex
@@ -1,4 +1,4 @@
-<%#= invisible wrapper div so JS handles this like the reply forms %>
+<% #= invisible wrapper div so JS handles this like the reply forms %>
 <div class="js-comment">
   <%= form_for @changeset,
     Routes.news_item_comment_path(@conn, :create),

diff --git a/lib/changelog_web/templates/page/_ten/ten_episodes.html.eex b/lib/changelog_web/templates/page/_ten/ten_episodes.html.eex
@@ -1,5 +1,5 @@
 <div class="ten-episodes">
-  <%# Ten years of Changelog https://changelog.com/backtage/9 %>
+  <% # Ten years of Changelog https://changelog.com/backtage/9 %>
   <div class="ten-episodes-item">
     <a
       role="button"
@@ -21,7 +21,7 @@
     </a>
   </div>
 
-  <%# A protocol for dying https://changelog.com/podcast/205 (edited) %>
+  <% # A protocol for dying https://changelog.com/podcast/205 (edited) %>
   <div class="ten-episodes-item">
     <a
       role="button"
@@ -43,7 +43,7 @@
     </a>
   </div>
 
- <%# Creating the Go programming language https://changelog.com/gotime/100 %>
+ <% # Creating the Go programming language https://changelog.com/gotime/100 %>
   <div class="ten-episodes-item">
     <a
       role="button"
@@ -65,7 +65,7 @@
     </a>
   </div>
 
-  <%# 99 practical bottles of OOP https://changelog.com/podcast/225 %>
+  <% # 99 practical bottles of OOP https://changelog.com/podcast/225 %>
   <div class="ten-episodes-item">
     <a
       role="button"
@@ -87,7 +87,7 @@
     </a>
   </div>
 
-  <%# Exposing the deception of DeepFakes https://changelog.com/practicalai/49 %>
+  <% # Exposing the deception of DeepFakes https://changelog.com/practicalai/49 %>
   <div class="ten-episodes-item">
     <a
       role="button"
@@ -109,7 +109,7 @@
     </a>
   </div>
 
-  <%# A call for kindness in open source https://changelog.com/podcast/318 %>
+  <% # A call for kindness in open source https://changelog.com/podcast/318 %>
   <div class="ten-episodes-item">
     <a
       role="button"
@@ -131,7 +131,7 @@
     </a>
   </div>
 
-  <%# Websites should work without JS. Yep? Nope? https://changelog.com/jsparty/87 %>
+  <% # Websites should work without JS. Yep? Nope? https://changelog.com/jsparty/87 %>
   <div class="ten-episodes-item">
     <a
       role="button"
@@ -153,7 +153,7 @@
     </a>
   </div>
 
-  <%# Why SQLite succeeded as a database https://changelog.com/podcast/201 %>
+  <% # Why SQLite succeeded as a database https://changelog.com/podcast/201 %>
   <div class="ten-episodes-item">
     <a
       role="button"
@@ -175,7 +175,7 @@
     </a>
   </div>
 
-  <%# Danielle Morrill on starting over from zero https://changelog.com/founderstalk/53 %>
+  <% # Danielle Morrill on starting over from zero https://changelog.com/founderstalk/53 %>
   <div class="ten-episodes-item">
     <a
       role="button"
@@ -197,7 +197,7 @@
     </a>
   </div>
 
-  <%# The beginnings of Microsoft Azure https://changelog.com/podcast/298 %>
+  <% # The beginnings of Microsoft Azure https://changelog.com/podcast/298 %>
   <div class="ten-episodes-item">
     <a
       role="button"
@@ -219,7 +219,7 @@
     </a>
   </div>
 
-  <%# Humans and habits https://changelog.com/brainscience/3 %>
+  <% # Humans and habits https://changelog.com/brainscience/3 %>
   <div class="ten-episodes-item">
     <a
       role="button"
@@ -241,7 +241,7 @@
     </a>
   </div>
 
-  <%# All things text mode https://changelog.com/podcast/340 %>
+  <% # All things text mode https://changelog.com/podcast/340 %>
   <div class="ten-episodes-item">
     <a
       role="button"

diff --git a/lib/changelog_web/templates/page/_ten/ten_gallery.html.eex b/lib/changelog_web/templates/page/_ten/ten_gallery.html.eex
@@ -16,7 +16,7 @@
   <a class="js-lightbox" href='<%= url(~p"/images/content/ten/photos/ten-photo-12.jpg") %>' data-gallery="gallery"  data-type="image">
     <img class="ten-gallery-image" src='<%= url(~p"/images/content/ten/photos/ten-photo-12-thumb.jpg") %>' alt="" />
   </a>
-  <%# Hidden photos that only appear in the gallery %>
+  <% # Hidden photos that only appear in the gallery %>
   <a href='<%= url(~p"/images/content/ten/photos/ten-photo-21.jpg") %>' class="visually_hidden js-lightbox" data-gallery="gallery" data-type="image"></a>
   <a href='<%= url(~p"/images/content/ten/photos/ten-photo-1.jpg") %>' class="visually_hidden js-lightbox" data-gallery="gallery"  data-type="image"></a>
   <a href='<%= url(~p"/images/content/ten/photos/ten-photo-4.jpg") %>' class="visually_hidden js-lightbox" data-gallery="gallery"  data-type="image"></a>

diff --git a/lib/changelog_web/templates/page/_ten/ten_stats.html.eex b/lib/changelog_web/templates/page/_ten/ten_stats.html.eex
@@ -1,4 +1,4 @@
-<%# TODO: Increment stats when scrolled into view %>
+<% # TODO: Increment stats when scrolled into view %>
 <div class="ten-stats">
   <div class="ten-stats-item">
     <h3 class="ten-stats-heading">

diff --git a/lib/changelog_web/templates/page/_ten/ten_testimonials.html.eex b/lib/changelog_web/templates/page/_ten/ten_testimonials.html.eex
@@ -1,4 +1,4 @@
-<%# NOTE: Testimonials support Twitter, Facebook, and Instagram icons %>
+<% # NOTE: Testimonials support Twitter, Facebook, and Instagram icons %>
 
 <div class="ten-testimonials">
   <div class="ten-testimonials-slider js-slider">

diff --git a/lib/changelog_web/templates/page/ten.html.eex b/lib/changelog_web/templates/page/ten.html.eex
@@ -1,10 +1,10 @@
-<%# TODO: Consider omitting default site footer for this page %>
+<% # TODO: Consider omitting default site footer for this page %>
 
 <article class="ten">
   <header class="ten-section ten-hero">
     <div class="ten-section-inner">
       <h1 class="ten-hero-logo">
-        <%# TODO: Add fallback logo and display based on a "cssmask" Modernizr check %>
+        <% # TODO: Add fallback logo and display based on a "cssmask" Modernizr check %>
         <div class="ten-hero-logo-background"></div>
         <div class="ten-hero-logo-main">
           <%= render("_ten/ten_year_logo.html", assigns) %>

diff --git a/lib/changelog_web/templates/podcast/_header_landing.html.eex b/lib/changelog_web/templates/podcast/_header_landing.html.eex
@@ -1,4 +1,4 @@
-<header class="show-header">
+  <header class="show-header">
   <h2 class="visually_hidden"><%= @podcast.name %></h2>
   <div class="show-header-inner">
 
@@ -41,7 +41,7 @@
       </div>
 
       <%= if Enum.any?(@podcast.active_hosts) do %>
-      <div class="show-header-hosts avatar_list <%= if length(@podcast.active_hosts) < 4, do: 'avatar_list--full' %>">
+      <div class="show-header-hosts avatar_list <%= if length(@podcast.active_hosts) < 4, do: "avatar_list--full" %>">
       <%= for person <- @podcast.active_hosts do %>
         <%= link to: PersonView.profile_path(person), class: "avatar_list-item", title: person.name do %>
           <%= SharedHelpers.lazy_image(PersonView.avatar_url(person), "Host Avatar", width: 60, height: 60) %>

diff --git a/lib/changelog_web/templates/shared/_richtext_player.html.eex b/lib/changelog_web/templates/shared/_richtext_player.html.eex
@@ -1,20 +1,20 @@
 <figure class="richtext-figure js-mini-player">
   <div
     class="richtext_player js-mini-player"
-    data-title="<%#= @title %>"
-    data-audio="<%#= @audio %>"
-    data-duration="<%#= @duration %>"
+    data-title="<% #= @title %>"
+    data-audio="<% #= @audio %>"
+    data-duration="<% #= @duration %>"
   >
-    <a href="<%#= @audio %>" class="richtext_player-button richtext_player-button--play js-player-play-button"></a>
+    <a href="<% #= @audio %>" class="richtext_player-button richtext_player-button--play js-player-play-button"></a>
     <form class="richtext_player-slider">
       <div class="range_slider">
         <div class="range_slider-range_wrap">
-          <input class="range_slider-range js-player-scrubber" type="range" value="0" min="0" max="<%#= @duration %>"/>
+          <input class="range_slider-range js-player-scrubber" type="range" value="0" min="0" max="<% #= @duration %>"/>
           <div class="range_slider-range-track js-player-track"></div>
         </div>
       </div>
     </form>
-    <output class="richtext_player-time"><span class="js-player-current">0:00</span> / <span class="js-player-duration"><%#= TimeView.duration(@duration) %> 9:99</span></output>
+    <output class="richtext_player-time"><span class="js-player-current">0:00</span> / <span class="js-player-duration"><% #= TimeView.duration(@duration) %> 9:99</span></output>
   </div>
   <figcaption>This independent workforce survey reveals new insights into freelancing in America. Key findings: Freelancers earned an estimated $1 trillion this year, are highly motivated, growing.</figcaption>
 </figure>
diff --git a/lib/changelog_web/templates/sponsor/index.html.eex b/lib/changelog_web/templates/sponsor/index.html.eex
@@ -14,7 +14,7 @@
       <p class="button_note">Or call us at 888-974-CHLG (2454)</p>
     </header>
 
-    <%# render("_marketing_slider.html", assigns) %>
+    <% # render("_marketing_slider.html", assigns) %>
   </section>
 
   <section class="marketing-section">

diff --git a/lib/changelog_web/views/admin/podcast_subscription_view.ex b/lib/changelog_web/views/admin/podcast_subscription_view.ex
@@ -7,7 +7,7 @@ defmodule ChangelogWeb.Admin.PodcastSubscriptionView do
 
   def day_chart_data(podcast) do
     stats =
-      Enum.map(30..0, fn i ->
+      Enum.map(30..0//-1, fn i ->
         start_date = Timex.today() |> Timex.shift(days: -i)
         start_time = start_date |> Timex.to_datetime() |> Timex.beginning_of_day()
         end_time = start_date |> Timex.to_datetime() |> Timex.end_of_day()
@@ -39,7 +39,7 @@ defmodule ChangelogWeb.Admin.PodcastSubscriptionView do
     this_month = Timex.today() |> Timex.beginning_of_month()
 
     stats =
-      Enum.map(11..0, fn i ->
+      Enum.map(11..0//-1, fn i ->
         start_date = Timex.shift(this_month, months: -i)
         start_time = start_date |> Timex.to_datetime() |> Timex.beginning_of_day()
         end_time = start_date |> Timex.end_of_month() |> Timex.to_datetime() |> Timex.end_of_day()

diff --git a/lib/changelog_web/views/admin/podcast_view.ex b/lib/changelog_web/views/admin/podcast_view.ex
@@ -19,7 +19,7 @@ defmodule ChangelogWeb.Admin.PodcastView do
   end
 
   def position_options do
-    1..Repo.count(Podcast.public())
+    Range.new(1, Repo.count(Podcast.public()), 1)
   end
 
   def subscribers_count(%{subscribers: nil}), do: 0

diff --git a/lib/changelog_web/views/album_view.ex b/lib/changelog_web/views/album_view.ex
@@ -27,8 +27,8 @@ defmodule ChangelogWeb.AlbumView do
 
   def header_art_attrs(album) do
     %{
-      src: art_url(album, 'full'),
-      srcset: "#{art_url(album, 'full')} 3000w, #{art_url(album, '512')} 440w",
+      src: art_url(album, "full"),
+      srcset: "#{art_url(album, "full")} 3000w, #{art_url(album, "512")} 440w",
       sizes: "(min-width:880px) 490w, 440w",
       alt: "#{album.name} Album Artwork"
     }

diff --git a/test/changelog_web/controllers/admin/news_item_subscription_controller_test.exs b/test/changelog_web/controllers/admin/news_item_subscription_controller_test.exs
@@ -26,7 +26,7 @@ defmodule ChangelogWeb.Admin.NewsItemSubscriptionControllerTest do
       ],
       fn conn ->
         assert html_response(conn, 302)
-        assert conn.halted()
+        assert conn.halted
       end
     )
   end

diff --git a/test/changelog_web/controllers/admin/podcast_subscription_controller_test.exs b/test/changelog_web/controllers/admin/podcast_subscription_controller_test.exs
@@ -26,7 +26,7 @@ defmodule ChangelogWeb.Admin.PodcastSubscriptionControllerTest do
       ],
       fn conn ->
         assert html_response(conn, 302)
-        assert conn.halted()
+        assert conn.halted
       end
     )
   end