Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add psr-15 example to examples folder #669

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shish
Copy link
Contributor

@shish shish commented Mar 22, 2024

Add psr-15 example to examples folder

This example is broken and I don't know why (maybe somebody who knows what they are doing can explain?). But at least now we can see that it is broken, which is better than just silently misleading people...

@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.31%. Comparing base (53f9d49) to head (a705281).
Report is 84 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #669      +/-   ##
============================================
- Coverage     95.72%   95.31%   -0.41%     
- Complexity     1773     1809      +36     
============================================
  Files           154      171      +17     
  Lines          4586     4783     +197     
============================================
+ Hits           4390     4559     +169     
- Misses          196      224      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

examples/psr-15/composer.lock Outdated Show resolved Hide resolved
@shish shish closed this Apr 17, 2024
@shish shish reopened this Apr 17, 2024
@shish shish force-pushed the pr669 branch 2 times, most recently from 5f19737 to 55551ba Compare April 21, 2024 20:36
This example is broken and I don't know why (maybe somebody who knows what they are doing can explain?). But at least now we can _see_ that it is broken, which is better than just silently misleading people...
@shish
Copy link
Contributor Author

shish commented Apr 23, 2024

So this is failing and I don't know why :( I tried the same fix which worked for the no-framework example, but no luck

$ cd examples/psr-15
$ composer install
$ php -S 127.0.0.1:8080
$ curl -X POST -d '{"query":"{ hello(name: \"World\") }"}' -H "Content-Type: application/json" http://localhost:8080/graphql
{"errors":[{"message":"Cannot query field \"hello\" on type \"Query\".","locations":[{"line":1,"column":3}]}]}%  

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants