Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix promoted default values #672

Merged

Conversation

oprypkhantc
Copy link
Contributor

Hey

Currently constructor promoted properties' default values are ignored, because ReflectionClass::getDefaultProperties() does not return default values from promoted props.

This fixes it, so the behaviour matches regular properties.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.28%. Comparing base (53f9d49) to head (e8f2c4a).
Report is 76 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #672      +/-   ##
============================================
- Coverage     95.72%   95.28%   -0.45%     
- Complexity     1773     1828      +55     
============================================
  Files           154      171      +17     
  Lines          4586     4854     +268     
============================================
+ Hits           4390     4625     +235     
- Misses          196      229      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oojacoboo oojacoboo merged commit 02c6131 into thecodingmachine:master Apr 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants