Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPStan 2 + GHA CI #35

Merged
merged 7 commits into from
Nov 22, 2024
Merged

PHPStan 2 + GHA CI #35

merged 7 commits into from
Nov 22, 2024

Conversation

Jean85
Copy link
Contributor

@Jean85 Jean85 commented Nov 21, 2024

No description provided.

@Jean85
Copy link
Contributor Author

Jean85 commented Nov 21, 2024

@moufmouf can you review this & enable Github actions?

@moufmouf
Copy link
Member

Ho, this is super cool! In order to enable Github actions, I have no way but merging a Github actions file into master.
So let's merge this PR. If anything goes wrong with CI, we can fix that in another PR.

Thanks @Jean85 !

@moufmouf moufmouf merged commit ccd3d55 into thecodingmachine:master Nov 22, 2024
@moufmouf
Copy link
Member

Alright, so we are facing a few issues: https://github.com/thecodingmachine/phpstan-safe-rule/actions/runs/11972945413

Would you mind opening another PR to fix those?

@Jean85 Jean85 mentioned this pull request Nov 22, 2024
@dbrekelmans dbrekelmans mentioned this pull request Nov 23, 2024
@Jean85 Jean85 deleted the phpstan-2 branch November 25, 2024 10:03
@Jean85
Copy link
Contributor Author

Jean85 commented Nov 25, 2024

@moufmouf #36 should fix it, in the meantime I also opened #37 for further work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants